Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2782)

Unified Diff: app/data_pack.h

Issue 5992006: Move data pack from base to app (it's just part of the resource bundle system... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « app/app_base.gypi ('k') | app/data_pack.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: app/data_pack.h
===================================================================
--- app/data_pack.h (revision 69975)
+++ app/data_pack.h (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -6,8 +6,8 @@
// (key, value) pairs of data. It's used to store static resources like
// translation strings and images.
-#ifndef BASE_DATA_PACK_H_
-#define BASE_DATA_PACK_H_
+#ifndef APP_DATA_PACK_H_
+#define APP_DATA_PACK_H_
#pragma once
#include <map>
@@ -15,15 +15,19 @@
#include "base/basictypes.h"
#include "base/scoped_ptr.h"
+namespace base {
+class StringPiece;
+}
+
namespace file_util {
- class MemoryMappedFile;
+class MemoryMappedFile;
}
+
class FilePath;
class RefCountedStaticMemory;
-namespace base {
-class StringPiece;
+namespace app {
class DataPack {
public:
@@ -36,7 +40,7 @@
// Get resource by id |resource_id|, filling in |data|.
// The data is owned by the DataPack object and should not be modified.
// Returns false if the resource id isn't found.
- bool GetStringPiece(uint32 resource_id, StringPiece* data) const;
+ bool GetStringPiece(uint32 resource_id, base::StringPiece* data) const;
// Like GetStringPiece(), but returns a reference to memory. This interface
// is used for image data, while the StringPiece interface is usually used
@@ -45,7 +49,7 @@
// Writes a pack file containing |resources| to |path|.
static bool WritePack(const FilePath& path,
- const std::map<uint32, StringPiece>& resources);
+ const std::map<uint32, base::StringPiece>& resources);
private:
// The memory-mapped data.
@@ -57,6 +61,6 @@
DISALLOW_COPY_AND_ASSIGN(DataPack);
};
-} // namespace base
+} // namespace app
-#endif // BASE_DATA_PACK_H_
+#endif // APP_DATA_PACK_H_
« no previous file with comments | « app/app_base.gypi ('k') | app/data_pack.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698