Issue 5991012: Make glVertexAttribPointer return INVALID_OPERATION for offsets...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5991012: Make glVertexAttribPointer return INVALID_OPERATION for offsets... (Closed)

Created:
9 years, 11 months ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
Zhenyao Mo

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make glVertexAttribPointer return INVALID_OPERATION for offsets and strides that do not match type. TEST=unit tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70800

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -6 lines)			Patch
	M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View		2 chunks	+8 lines, -3 lines	0 comments	Download
	M	gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc	View	1	3 chunks	+139 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Zhenyao Mo

http://codereview.chromium.org/5991012/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): http://codereview.chromium.org/5991012/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode4718 gpu/command_buffer/service/gles2_cmd_decoder.cc:4718: SetGLError(GL_INVALID_OPERATION, I think here we should check if (stride ...

9 years, 11 months ago (2011-01-05 23:54:11 UTC) #2