Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 5990013: Linux: change gyp and add a shim header to build with system speex.... (Closed)

Created:
9 years, 11 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
Satish
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: change gyp and add a shim header to build with system speex. This will be useful for Linux distributions shipping Chromium. The default setting is still to build with the bundled speex library. More changes will be required (in src). This is the part in deps. BUG=68524 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70427

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -78 lines) Patch
A speex.h View 1 chunk +18 lines, -0 lines 2 comments Download
M speex.gyp View 1 chunk +108 lines, -78 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
9 years, 11 months ago (2011-01-04 15:40:50 UTC) #1
Satish
http://codereview.chromium.org/5990013/diff/1/speex.h File speex.h (right): http://codereview.chromium.org/5990013/diff/1/speex.h#newcode15 speex.h:15: #include "third_party/speex/include/speex/speex.h" can you also update the files which ...
9 years, 11 months ago (2011-01-04 16:10:27 UTC) #2
Paweł Hajdan Jr.
http://codereview.chromium.org/5990013/diff/1/speex.h File speex.h (right): http://codereview.chromium.org/5990013/diff/1/speex.h#newcode15 speex.h:15: #include "third_party/speex/include/speex/speex.h" On 2011/01/04 16:10:28, Satish wrote: > can ...
9 years, 11 months ago (2011-01-04 16:44:15 UTC) #3
Satish
9 years, 11 months ago (2011-01-04 16:46:36 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698