speex.h - Issue 5990013: Linux: change gyp and add a shim header to build with system speex....

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: speex.h

Issue 5990013: Linux: change gyp and add a shim header to build with system speex.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/speex/

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

Property Changes:

Added: svn:eol-style
+ LF

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef THIRD_PARTY_SPEEX_SPEEX_H_

	6 #define THIRD_PARTY_SPEEX_SPEEX_H_

	7 #pragma once

	8

	9 // This is a shim header to include the right speex header.

	10 // Use this instead of referencing the speex header directly.

	11

	12 #if defined(USE_SYSTEM_SPEEX)

	13 #include <speex/speex.h>

	14 #else

	15 #include "third_party/speex/include/speex/speex.h"
	Satish 2011/01/04 16:10:28 can you also update the files which currently incl can you also update the files which currently include this header file to point to the new path? I remember src/chrome/browser/speech/speech_recognizer.cc is one of them, not sure if there are more. Paweł Hajdan Jr. 2011/01/04 16:44:15 Yes, that's definitely my plan. Note however that Show quoted text On 2011/01/04 16:10:28, Satish wrote: > can you also update the files which currently include this header file to point > to the new path? I remember src/chrome/browser/speech/speech_recognizer.cc is > one of them, not sure if there are more. Yes, that's definitely my plan. Note however that this is change in deps/ and the other files are in src/ . We'll need to land this change, roll DEPS for speex, and finally update src (yes, there's just one file you've mentioned to update). I used that sequence for icu (another library that sits in deps), and it worked fine without breaking the tree at any point.
	16 #endif

	17

	18 #endif // THIRD_PARTY_SPEEX_SPEEX_H_

OLD	NEW

« no previous file with comments | « no previous file | speex.gyp » ('j') | no next file with comments »