Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1820)

Unified Diff: views/controls/textfield/native_textfield_win.h

Issue 5988010: focus reverse traversal was not working for TextfieldViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: explicitly forward key/focus event to TextfieldViews Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/controls/textfield/native_textfield_win.h
diff --git a/views/controls/textfield/native_textfield_win.h b/views/controls/textfield/native_textfield_win.h
index 5dc882f9ed020e218c8f390f03f630d4960876ab..c8a7ad664ec01dff8e89fa39daf1cca93682c58e 100644
--- a/views/controls/textfield/native_textfield_win.h
+++ b/views/controls/textfield/native_textfield_win.h
@@ -22,9 +22,9 @@
namespace views {
+class Menu2;
class NativeViewHost;
class Textfield;
-class Menu2;
static const int kDefaultEditStyle = WS_CHILD | WS_VISIBLE | WS_CLIPCHILDREN |
WS_CLIPSIBLINGS;
@@ -62,10 +62,15 @@ class NativeTextfieldWin
virtual gfx::Insets CalculateInsets();
virtual void UpdateHorizontalMargins();
virtual void UpdateVerticalMargins();
- virtual void SetFocus();
+ virtual bool SetFocus();
virtual View* GetView();
virtual gfx::NativeView GetTestingHandle() const;
virtual bool IsIMEComposing() const;
+ virtual bool OnKeyPressed(const views::KeyEvent& e) { return false; }
sky 2011/01/05 22:57:35 Don't inline virtual methods.
+ virtual bool OnKeyReleased(const views::KeyEvent& e) { return false; }
+ virtual void WillGainFocus() {}
+ virtual void DidGainFocus() {}
+ virtual void WillLoseFocus() {}
// Overridden from menus::SimpleMenuModel::Delegate:
virtual bool IsCommandIdChecked(int command_id) const;

Powered by Google App Engine
This is Rietveld 408576698