views/controls/textfield/native_textfield_win.cc - Issue 5988010: focus reverse traversal was not working for TextfieldViews.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/controls/textfield/native_textfield_win.cc

Issue 5988010: focus reverse traversal was not working for TextfieldViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: explicitly forward key/focus event to TextfieldViews Created 9 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: views/controls/textfield/native_textfield_win.cc

diff --git a/views/controls/textfield/native_textfield_win.cc b/views/controls/textfield/native_textfield_win.cc

index 581e40f2bb0d1316e40c9e8586f07e51b9aafe9a..b79c3654d7a8a17395a6b411c63d20e7defbf076 100644

--- a/views/controls/textfield/native_textfield_win.cc

+++ b/views/controls/textfield/native_textfield_win.cc

@@ -274,10 +274,11 @@ void NativeTextfieldWin::UpdateVerticalMargins() {

NOTIMPLEMENTED();

}

-void NativeTextfieldWin::SetFocus() {

+bool NativeTextfieldWin::SetFocus() {

// Focus the associated HWND.

//container_view_->Focus();

::SetFocus(m_hWnd);

+ return true;

}

View* NativeTextfieldWin::GetView() {