Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: views/controls/textfield/native_textfield_views.h

Issue 5988010: focus reverse traversal was not working for TextfieldViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/controls/textfield/native_textfield_views.h
diff --git a/views/controls/textfield/native_textfield_views.h b/views/controls/textfield/native_textfield_views.h
index cfb47be3dee691a57046797d4ac4831c4518f872..3c023ac56b74a6d75dfd4860b6b2bc4b6e7f9abe 100644
--- a/views/controls/textfield/native_textfield_views.h
+++ b/views/controls/textfield/native_textfield_views.h
@@ -46,11 +46,11 @@ class NativeTextfieldViews : public views::View,
virtual bool OnKeyPressed(const views::KeyEvent& e);
virtual bool OnKeyReleased(const views::KeyEvent& e);
virtual void Paint(gfx::Canvas* canvas);
+ virtual void DidChangeBounds(const gfx::Rect& previous,
+ const gfx::Rect& current);
virtual void WillGainFocus();
virtual void DidGainFocus();
virtual void WillLoseFocus();
- virtual void DidChangeBounds(const gfx::Rect& previous,
- const gfx::Rect& current);
// NativeTextfieldWrapper overrides:
virtual string16 GetText() const;
@@ -66,14 +66,18 @@ class NativeTextfieldViews : public views::View,
virtual void UpdateFont();
virtual void UpdateIsPassword();
virtual void UpdateEnabled();
- virtual bool IsPassword();
virtual gfx::Insets CalculateInsets();
virtual void UpdateHorizontalMargins();
virtual void UpdateVerticalMargins();
- virtual void SetFocus();
+ virtual bool SetFocus();
virtual View* GetView();
virtual gfx::NativeView GetTestingHandle() const;
virtual bool IsIMEComposing() const;
+ virtual bool HandleKeyPressed(const views::KeyEvent& e);
+ virtual bool HandleKeyReleased(const views::KeyEvent& e);
+ virtual void HandleWillGainFocus();
+ virtual void HandleDidGainFocus();
+ virtual void HandleWillLoseFocus();
// class name of internal
static const char kViewClassName[];
« no previous file with comments | « views/controls/textfield/native_textfield_gtk.cc ('k') | views/controls/textfield/native_textfield_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698