Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: views/controls/textfield/native_textfield_gtk.cc

Issue 5988010: focus reverse traversal was not working for TextfieldViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/controls/textfield/native_textfield_gtk.h ('k') | views/controls/textfield/native_textfield_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/controls/textfield/native_textfield_gtk.cc
diff --git a/views/controls/textfield/native_textfield_gtk.cc b/views/controls/textfield/native_textfield_gtk.cc
index 3026defe1c1e78b213ef6bf28b9f576ffe1403dc..2271156c3da0a6f10e7c88fdfd136d6935e81f56 100644
--- a/views/controls/textfield/native_textfield_gtk.cc
+++ b/views/controls/textfield/native_textfield_gtk.cc
@@ -257,10 +257,6 @@ void NativeTextfieldGtk::UpdateEnabled() {
SetEnabled(textfield_->IsEnabled());
}
-bool NativeTextfieldGtk::IsPassword() {
- return textfield_->IsPassword();
-}
-
gfx::Insets NativeTextfieldGtk::CalculateInsets() {
if (!native_view())
return gfx::Insets();
@@ -329,8 +325,9 @@ void NativeTextfieldGtk::UpdateVerticalMargins() {
}
}
-void NativeTextfieldGtk::SetFocus() {
+bool NativeTextfieldGtk::SetFocus() {
Focus();
+ return true;
}
View* NativeTextfieldGtk::GetView() {
@@ -345,6 +342,23 @@ bool NativeTextfieldGtk::IsIMEComposing() const {
return false;
}
+bool NativeTextfieldGtk::HandleKeyPressed(const views::KeyEvent& e) {
+ return false;
+}
+
+bool NativeTextfieldGtk::HandleKeyReleased(const views::KeyEvent& e) {
+ return false;
+}
+
+void NativeTextfieldGtk::HandleWillGainFocus() {
+}
+
+void NativeTextfieldGtk::HandleDidGainFocus() {
+}
+
+void NativeTextfieldGtk::HandleWillLoseFocus() {
+}
+
// static
gboolean NativeTextfieldGtk::OnKeyPressEventHandler(
GtkWidget* widget,
@@ -444,4 +458,8 @@ void NativeTextfieldGtk::NativeControlCreated(GtkWidget* widget) {
g_signal_connect(widget, "activate", G_CALLBACK(OnActivateHandler), this);
}
+bool NativeTextfieldGtk::IsPassword() {
+ return textfield_->IsPassword();
+}
+
} // namespace views
« no previous file with comments | « views/controls/textfield/native_textfield_gtk.h ('k') | views/controls/textfield/native_textfield_views.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698