Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issue 598065: Change CallIC interface on ARM. Remove name from the stack, and pass it in r... (Closed)

Created:
10 years, 10 months ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Change CallIC interface on ARM. Remove name from the stack, and pass it in register r2. Committed: http://code.google.com/p/v8/source/detail?r=3856

Patch Set 1 #

Total comments: 10

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -116 lines) Patch
M src/arm/builtins-arm.cc View 1 3 chunks +31 lines, -32 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 5 chunks +7 lines, -22 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 7 chunks +10 lines, -17 lines 0 comments Download
M src/arm/ic-arm.cc View 1 5 chunks +12 lines, -15 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 15 chunks +30 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
10 years, 10 months ago (2010-02-11 15:43:37 UTC) #1
Kevin Millikin (Chromium)
LGTM. http://codereview.chromium.org/598065/diff/1/3 File src/arm/builtins-arm.cc (right): http://codereview.chromium.org/598065/diff/1/3#newcode1016 src/arm/builtins-arm.cc:1016: // 5. Shift arguments and return address one ...
10 years, 10 months ago (2010-02-12 12:32:24 UTC) #2
William Hesse
10 years, 10 months ago (2010-02-15 13:17:44 UTC) #3
http://codereview.chromium.org/598065/diff/1/3
File src/arm/builtins-arm.cc (right):

http://codereview.chromium.org/598065/diff/1/3#newcode1016
src/arm/builtins-arm.cc:1016: // 5. Shift arguments and return address one slot
toward the bottom of the
On 2010/02/12 12:32:24, Kevin Millikin wrote:
> Return address is in lr, isn't it?

Done.

http://codereview.chromium.org/598065/diff/1/3#newcode1030
src/arm/builtins-arm.cc:1030: __ add(sp, sp, Operand(kPointerSize));
On 2010/02/12 12:32:24, Kevin Millikin wrote:
> You can write __ pop();.

Done.

http://codereview.chromium.org/598065/diff/1/3#newcode1041
src/arm/builtins-arm.cc:1041: __ ldr(r3, MemOperand(r3,
SharedFunctionInfo::kCodeOffset - kHeapObjectTag));
On 2010/02/12 12:32:24, Kevin Millikin wrote:
> FieldMemOperand(r3, SharedFunctionInfo::kCodeOffset)

Done.

http://codereview.chromium.org/598065/diff/1/6
File src/arm/ic-arm.cc (right):

http://codereview.chromium.org/598065/diff/1/6#newcode303
src/arm/ic-arm.cc:303: __ ldr(r0, MemOperand(sp, argc * kPointerSize));
On 2010/02/12 12:32:24, Kevin Millikin wrote:
> I don't think this one needed to be changed but it's OK.

Done.

http://codereview.chromium.org/598065/diff/1/6#newcode385
src/arm/ic-arm.cc:385: __ push(r1);
On 2010/02/12 12:32:24, Kevin Millikin wrote:
> This is a case where you can keep stm by choosing r3 for the receiver.

Done.

Powered by Google App Engine
This is Rietveld 408576698