Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 598059: Fix problem with GenericBinaryOperationStub::GenerateCall for a Smi... (Closed)

Created:
10 years, 10 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix problem with GenericBinaryOperationStub::GenerateCall for a Smi left operand. For non-commutative operations the right operand could be overwritten with the Smi left operand. We need better testing of all of these cases. We will add more test cases as a separate commit. Committed: http://code.google.com/p/v8/source/detail?r=3834

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M src/ia32/codegen-ia32.cc View 4 chunks +11 lines, -3 lines 0 comments Download
M src/x64/codegen-x64.cc View 4 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
Please double check this carefully. We need to generate regression test cases for this.
10 years, 10 months ago (2010-02-11 11:41:09 UTC) #1
Kevin Millikin (Chromium)
10 years, 10 months ago (2010-02-11 12:05:57 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698