Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: chrome/test/automation/automation_proxy.cc

Issue 5978003: Make IPC::Channel::Listener:OnMessageReceived have a return value indicating ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/automation/automation_proxy.h ('k') | chrome/test/automation/automation_proxy_uitest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/automation/automation_proxy.cc
===================================================================
--- chrome/test/automation/automation_proxy.cc (revision 70108)
+++ chrome/test/automation/automation_proxy.cc (working copy)
@@ -42,17 +42,16 @@
// the message be handled in the default way.
virtual bool OnMessageReceived(const IPC::Message& message) {
bool handled = true;
-
IPC_BEGIN_MESSAGE_MAP(AutomationMessageFilter, message)
IPC_MESSAGE_HANDLER_GENERIC(AutomationMsg_Hello,
- OnAutomationHello(message));
+ OnAutomationHello(message))
IPC_MESSAGE_HANDLER_GENERIC(
- AutomationMsg_InitialLoadsComplete, server_->SignalInitialLoads());
+ AutomationMsg_InitialLoadsComplete, server_->SignalInitialLoads())
IPC_MESSAGE_HANDLER(AutomationMsg_InitialNewTabUILoadComplete,
- NewTabLoaded);
+ NewTabLoaded)
IPC_MESSAGE_HANDLER_GENERIC(
- AutomationMsg_InvalidateHandle, server_->InvalidateHandle(message));
- IPC_MESSAGE_UNHANDLED(handled = false);
+ AutomationMsg_InvalidateHandle, server_->InvalidateHandle(message))
+ IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
return handled;
@@ -379,10 +378,11 @@
channel_.reset();
}
-void AutomationProxy::OnMessageReceived(const IPC::Message& msg) {
+bool AutomationProxy::OnMessageReceived(const IPC::Message& msg) {
// This won't get called unless AutomationProxy is run from
// inside a message loop.
NOTREACHED();
+ return false;
}
void AutomationProxy::OnChannelError() {
« no previous file with comments | « chrome/test/automation/automation_proxy.h ('k') | chrome/test/automation/automation_proxy_uitest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698