Issue 597005: Ported ia32 optimization of revision 3487 to x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 597005: Ported ia32 optimization of revision 3487 to x64. (Closed)

Created:
10 years, 10 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Ported ia32 optimization of revision 3487 to x64.

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+139 lines, -55 lines)			Patch
M	src/x64/assembler-x64.h	View	2 chunks	+4 lines, -8 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/codegen-x64.cc	View	6 chunks	+46 lines, -6 lines	1 comment	Download
M	src/x64/disasm-x64.cc	View	3 chunks	+55 lines, -40 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

10 years, 10 months ago (2010-02-09 12:24:01 UTC) #2

LGTM

http://codereview.chromium.org/597005/diff/1/4
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/597005/diff/1/4#newcode4948
src/x64/codegen-x64.cc:4948: if (&& right_val->IsSmi()) {
is_for_loop_compare missing before &&?

Expand Messages | Collapse Messages