Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/background_mode_manager.cc

Issue 5968009: Change extension unload notification to indicate updates.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/background_contents_service.cc ('K') | « chrome/browser/background_contents_service.cc ('k') | chrome/browser/background_page_tracker.cc » ('j') | chrome/common/extensions/extension.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/background_mode_manager.cc
===================================================================
--- chrome/browser/background_mode_manager.cc (revision 69996)
+++ chrome/browser/background_mode_manager.cc (working copy)
@@ -129,7 +129,7 @@
break;
case NotificationType::EXTENSION_UNLOADED:
if (BackgroundApplicationListModel::IsBackgroundApp(
- *Details<Extension>(details).ptr())) {
+ *Details<UnloadedExtensionInfo>(details)->extension)) {
Erik does not do reviews 2010/12/23 17:05:17 same NULL comment here since I assume IsBackground
asargent_no_longer_on_chrome 2010/12/23 18:53:04 It turns out it can't be NULL.
OnBackgroundAppUnloaded();
}
break;
@@ -377,4 +377,3 @@
return background_mode_enabled;
}
-
« chrome/browser/background_contents_service.cc ('K') | « chrome/browser/background_contents_service.cc ('k') | chrome/browser/background_page_tracker.cc » ('j') | chrome/common/extensions/extension.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698