Refactor UITestBase/ProxyLauncher.

chrome/test/automation/automation_proxy_uitest.h

Index: chrome/test/automation/automation_proxy_uitest.h
diff --git a/chrome/test/automation/automation_proxy_uitest.h b/chrome/test/automation/automation_proxy_uitest.h
index 0b5556fa5a50176bbbda9bc76e420547564001c3..8f96038bc451144f2cad9d1eb6c0ecd102ba6369 100644
--- a/chrome/test/automation/automation_proxy_uitest.h
+++ b/chrome/test/automation/automation_proxy_uitest.h
@@ -107,7 +107,9 @@ class ExternalTabUITestMockClient : public AutomationProxy {
 // Base your external tab UI tests on this.
 class ExternalTabUITest : public UITest {
  public:
-  ExternalTabUITest() : UITest(MessageLoop::TYPE_UI) {}
+  ExternalTabUITest() : UITest(MessageLoop::TYPE_UI) {
+    launcher_.reset(CreateProxyLauncher());

[Paweł Hajdan Jr., 2011/01/05 21:47:59]

Why do we have to explicitly reset launcher_ here? It should be sufficient to
override CreateProxyLauncher.

[dtu, 2011/01/06 01:41:13]

Because the ProxyLauncher is now created in the constructor of UITestBase, and
class overrides that constructor. See comment in ui_test.cc.

+  }
   // Override UITest's CreateProxyLauncher to provide the unit test
   // with our special implementation of AutomationProxy.
   // This function is called from within UITest::SetUp().