Refactor UITestBase/ProxyLauncher.

chrome/test/automation/automation_proxy_uitest.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_UITEST_H_
 #define CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_UITEST_H_
 #pragma once
 
 #include <string>
 
@@ skipping 89 matching lines @@
   gfx::NativeWindow host_window_;
 
   // Simple dispatcher to above OnXXX methods.
   virtual bool OnMessageReceived(const IPC::Message& msg);
   virtual void InvalidateHandle(const IPC::Message& message);
 };
 
 // Base your external tab UI tests on this.
 class ExternalTabUITest : public UITest {
  public:
-  ExternalTabUITest() : UITest(MessageLoop::TYPE_UI) {}
+  ExternalTabUITest() : UITest(MessageLoop::TYPE_UI) {
+    launcher_.reset(CreateProxyLauncher());

[Paweł Hajdan Jr., 2011/01/05 21:47:59]

Why do we have to explicitly reset launcher_ here? It should be sufficient to
override CreateProxyLauncher.

[dtu, 2011/01/06 01:41:13]

Because the ProxyLauncher is now created in the constructor of UITestBase, and
class overrides that constructor. See comment in ui_test.cc.

+  }
   // Override UITest's CreateProxyLauncher to provide the unit test
   // with our special implementation of AutomationProxy.
   // This function is called from within UITest::SetUp().
   virtual ProxyLauncher* CreateProxyLauncher();
  protected:
   // Filtered Inet will override automation callbacks for network resources.
   virtual bool ShouldFilterInet() {
     return false;
   }
   ExternalTabUITestMockClient* mock_;
   std::string channel_id_;      // Channel id of automation proxy.
 };
 
 #endif  // CHROME_TEST_AUTOMATION_AUTOMATION_PROXY_UITEST_H_