Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: chrome/common/logging_chrome_uitest.cc

Issue 5967003: Refactor UITestBase/ProxyLauncher. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Add POD struct to hold some launcher variables. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/logging_chrome_uitest.cc
diff --git a/chrome/common/logging_chrome_uitest.cc b/chrome/common/logging_chrome_uitest.cc
index 96e3205b2d1670deeb0993b96844386327903b08..5d4236afe31497d5f6a161793a59a0cbc09ad8f1 100644
--- a/chrome/common/logging_chrome_uitest.cc
+++ b/chrome/common/logging_chrome_uitest.cc
@@ -98,7 +98,7 @@ class AssertionTest : public UITest {
#define Assertion DISABLED_Assertion
#endif
TEST_F(AssertionTest, Assertion) {
- if (UITest::in_process_renderer()) {
+ if (ProxyLauncher::in_process_renderer()) {
// in process mode doesn't do the crashing.
expected_errors_ = 0;
expected_crashes_ = 0;
@@ -133,7 +133,7 @@ class CheckFalseTest : public UITest {
#endif
// Launch the app in assertion test mode, then close the app.
TEST_F(CheckFalseTest, CheckFails) {
- if (UITest::in_process_renderer()) {
+ if (ProxyLauncher::in_process_renderer()) {
// in process mode doesn't do the crashing.
expected_errors_ = 0;
expected_crashes_ = 0;
@@ -171,7 +171,7 @@ class RendererCrashTest : public UITest {
#endif
// Launch the app in renderer crash test mode, then close the app.
TEST_F(RendererCrashTest, Crash) {
- if (UITest::in_process_renderer()) {
+ if (ProxyLauncher::in_process_renderer()) {
// in process mode doesn't do the crashing.
expected_crashes_ = 0;
} else {

Powered by Google App Engine
This is Rietveld 408576698