Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Side by Side Diff: chrome/common/logging_chrome_uitest.cc

Issue 5967003: Refactor UITestBase/ProxyLauncher. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Add POD struct to hold some launcher variables. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "build/build_config.h" 5 #include "build/build_config.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #endif 9 #endif
10 10
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 91
92 // Launch the app in assertion test mode, then close the app. 92 // Launch the app in assertion test mode, then close the app.
93 #if defined(OS_WIN) 93 #if defined(OS_WIN)
94 // http://crbug.com/26715 94 // http://crbug.com/26715
95 #define Assertion DISABLED_Assertion 95 #define Assertion DISABLED_Assertion
96 #elif defined(OS_MACOSX) 96 #elif defined(OS_MACOSX)
97 // Crash service doesn't exist for the Mac yet: http://crbug.com/45243 97 // Crash service doesn't exist for the Mac yet: http://crbug.com/45243
98 #define Assertion DISABLED_Assertion 98 #define Assertion DISABLED_Assertion
99 #endif 99 #endif
100 TEST_F(AssertionTest, Assertion) { 100 TEST_F(AssertionTest, Assertion) {
101 if (UITest::in_process_renderer()) { 101 if (ProxyLauncher::in_process_renderer()) {
102 // in process mode doesn't do the crashing. 102 // in process mode doesn't do the crashing.
103 expected_errors_ = 0; 103 expected_errors_ = 0;
104 expected_crashes_ = 0; 104 expected_crashes_ = 0;
105 } else { 105 } else {
106 expected_errors_ = 1; 106 expected_errors_ = 1;
107 expected_crashes_ = EXPECTED_ASSERT_CRASHES; 107 expected_crashes_ = EXPECTED_ASSERT_CRASHES;
108 } 108 }
109 } 109 }
110 #endif // !defined(NDEBUG) 110 #endif // !defined(NDEBUG)
111 111
(...skipping 14 matching lines...) Expand all
126 126
127 #if defined(OS_WIN) 127 #if defined(OS_WIN)
128 // http://crbug.com/38497 128 // http://crbug.com/38497
129 #define CheckFails FLAKY_CheckFails 129 #define CheckFails FLAKY_CheckFails
130 #elif defined(OS_MACOSX) 130 #elif defined(OS_MACOSX)
131 // Crash service doesn't exist for the Mac yet: http://crbug.com/45243 131 // Crash service doesn't exist for the Mac yet: http://crbug.com/45243
132 #define CheckFails DISABLED_CheckFails 132 #define CheckFails DISABLED_CheckFails
133 #endif 133 #endif
134 // Launch the app in assertion test mode, then close the app. 134 // Launch the app in assertion test mode, then close the app.
135 TEST_F(CheckFalseTest, CheckFails) { 135 TEST_F(CheckFalseTest, CheckFails) {
136 if (UITest::in_process_renderer()) { 136 if (ProxyLauncher::in_process_renderer()) {
137 // in process mode doesn't do the crashing. 137 // in process mode doesn't do the crashing.
138 expected_errors_ = 0; 138 expected_errors_ = 0;
139 expected_crashes_ = 0; 139 expected_crashes_ = 0;
140 } else { 140 } else {
141 expected_errors_ = 1; 141 expected_errors_ = 1;
142 expected_crashes_ = EXPECTED_ASSERT_CRASHES; 142 expected_crashes_ = EXPECTED_ASSERT_CRASHES;
143 } 143 }
144 } 144 }
145 #endif // !defined(OFFICIAL_BUILD) 145 #endif // !defined(OFFICIAL_BUILD)
146 146
(...skipping 17 matching lines...) Expand all
164 164
165 #if defined(OS_CHROMEOS) 165 #if defined(OS_CHROMEOS)
166 // http://crbug.com/43115 166 // http://crbug.com/43115
167 #define Crash DISABLED_Crash 167 #define Crash DISABLED_Crash
168 #elif defined(OS_MACOSX) 168 #elif defined(OS_MACOSX)
169 // Crash service doesn't exist for the Mac yet: http://crbug.com/45243 169 // Crash service doesn't exist for the Mac yet: http://crbug.com/45243
170 #define Crash DISABLED_Crash 170 #define Crash DISABLED_Crash
171 #endif 171 #endif
172 // Launch the app in renderer crash test mode, then close the app. 172 // Launch the app in renderer crash test mode, then close the app.
173 TEST_F(RendererCrashTest, Crash) { 173 TEST_F(RendererCrashTest, Crash) {
174 if (UITest::in_process_renderer()) { 174 if (ProxyLauncher::in_process_renderer()) {
175 // in process mode doesn't do the crashing. 175 // in process mode doesn't do the crashing.
176 expected_crashes_ = 0; 176 expected_crashes_ = 0;
177 } else { 177 } else {
178 scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0)); 178 scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
179 ASSERT_TRUE(browser.get()); 179 ASSERT_TRUE(browser.get());
180 ASSERT_TRUE(browser->WaitForTabCountToBecome(1)); 180 ASSERT_TRUE(browser->WaitForTabCountToBecome(1));
181 expected_crashes_ = EXPECTED_CRASH_CRASHES; 181 expected_crashes_ = EXPECTED_CRASH_CRASHES;
182 } 182 }
183 } 183 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698