Issue 5964013: OnKeyPress was not returning true when keypress is handled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5964013: OnKeyPress was not returning true when keypress is handled. (Closed)

Created:
9 years, 12 months ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
sadrul, sky, varunjain

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

OnKeyPress was not returning true when keypress is handled. BUG=none TEST=TestOnKeyPressReturnValue is added. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70424

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
	M	views/controls/textfield/native_textfield_views.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	views/controls/textfield/native_textfield_views_unittest.cc	View		2 chunks	+13 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

LGTM