Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: views/controls/textfield/native_textfield_views_unittest.cc

Issue 5964013: OnKeyPress was not returning true when keypress is handled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/controls/textfield/native_textfield_views.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/controls/textfield/native_textfield_views_unittest.cc
diff --git a/views/controls/textfield/native_textfield_views_unittest.cc b/views/controls/textfield/native_textfield_views_unittest.cc
index ed69e54b2046d37c8d977588c79ddf2f9873512f..eecac8ec9b74ec4075189f81515a0b11a33c8849 100644
--- a/views/controls/textfield/native_textfield_views_unittest.cc
+++ b/views/controls/textfield/native_textfield_views_unittest.cc
@@ -71,17 +71,17 @@ class NativeTextfieldViewsTest : public ::testing::Test,
model_ = textfield_view_->model_.get();
}
- void SendKeyEventToTextfieldViews(app::KeyboardCode key_code,
+ bool SendKeyEventToTextfieldViews(app::KeyboardCode key_code,
bool shift,
bool control) {
int flags = (shift ? KeyEvent::EF_SHIFT_DOWN : 0) |
(control ? KeyEvent::EF_CONTROL_DOWN : 0);
KeyEvent event(KeyEvent::ET_KEY_PRESSED, key_code, flags, 1, 0);
- textfield_view_->OnKeyPressed(event);
+ return textfield_view_->OnKeyPressed(event);
}
- void SendKeyEventToTextfieldViews(app::KeyboardCode key_code) {
- SendKeyEventToTextfieldViews(key_code, false, false);
+ bool SendKeyEventToTextfieldViews(app::KeyboardCode key_code) {
+ return SendKeyEventToTextfieldViews(key_code, false, false);
}
protected:
@@ -223,4 +223,13 @@ TEST_F(NativeTextfieldViewsTest, PasswordTest) {
EXPECT_STR_EQ("my password", last_contents_);
}
+TEST_F(NativeTextfieldViewsTest, TestOnKeyPressReturnValue) {
+ InitTextfield(Textfield::STYLE_DEFAULT);
+ EXPECT_TRUE(SendKeyEventToTextfieldViews(app::VKEY_A));
+ // F24, up/down key won't be handled.
+ EXPECT_FALSE(SendKeyEventToTextfieldViews(app::VKEY_F24));
+ EXPECT_FALSE(SendKeyEventToTextfieldViews(app::VKEY_UP));
+ EXPECT_FALSE(SendKeyEventToTextfieldViews(app::VKEY_DOWN));
+}
+
} // namespace views
« no previous file with comments | « views/controls/textfield/native_textfield_views.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698