Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5959008: Remove wstring from l10n_util. Part 2.... (Closed)

Created:
9 years, 12 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Paweł Hajdan Jr., darin-cc_chromium.org, rdsmith+dwatch_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Remove wstring from l10n_util. Part 2. BUG=9911 TEST=no visible changes; all tests pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70242

Patch Set 1 #

Total comments: 11

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -271 lines) Patch
M app/l10n_util.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M app/l10n_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M app/l10n_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/browser/content_exceptions_table_model.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M chrome/browser/download/download_item_model.h View 1 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/download/download_item_model.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/download/download_util.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/download/download_util.cc View 1 5 chunks +21 lines, -20 lines 0 comments Download
M chrome/browser/geolocation/geolocation_exceptions_table_model.cc View 1 chunk +13 lines, -8 lines 0 comments Download
M chrome/browser/gtk/download_item_gtk.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 5 chunks +69 lines, -63 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ssl/ssl_error_info.h View 2 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/ssl/ssl_error_info.cc View 3 chunks +87 lines, -83 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 2 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/ui/browser.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_cell.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration.mm View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration_unittest.mm View 1 2 chunks +2 lines, -1 line 0 comments Download
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/download_item_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
9 years, 12 months ago (2010-12-28 21:04:03 UTC) #1
Evan Stade
http://codereview.chromium.org/5959008/diff/1/app/l10n_util.h File app/l10n_util.h (right): http://codereview.chromium.org/5959008/diff/1/app/l10n_util.h#newcode186 app/l10n_util.h:186: // Convenience formatters for a single number. can you ...
9 years, 12 months ago (2010-12-28 21:23:08 UTC) #2
Avi (use Gerrit)
http://codereview.chromium.org/5959008/diff/1/app/l10n_util.h File app/l10n_util.h (right): http://codereview.chromium.org/5959008/diff/1/app/l10n_util.h#newcode186 app/l10n_util.h:186: // Convenience formatters for a single number. On 2010/12/28 ...
9 years, 12 months ago (2010-12-28 21:35:44 UTC) #3
Evan Stade
9 years, 12 months ago (2010-12-28 21:48:26 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698