Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Side by Side Diff: chrome/browser/ssl/ssl_error_info.cc

Issue 5959008: Remove wstring from l10n_util. Part 2.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ssl/ssl_error_info.h ('k') | chrome/browser/tab_contents/tab_contents.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ssl/ssl_error_info.h" 5 #include "chrome/browser/ssl/ssl_error_info.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "chrome/browser/cert_store.h" 9 #include "chrome/browser/cert_store.h"
10 #include "chrome/common/time_format.h" 10 #include "chrome/common/time_format.h"
11 #include "googleurl/src/gurl.h" 11 #include "googleurl/src/gurl.h"
12 #include "grit/chromium_strings.h" 12 #include "grit/chromium_strings.h"
13 #include "grit/generated_resources.h" 13 #include "grit/generated_resources.h"
14 #include "net/base/cert_status_flags.h" 14 #include "net/base/cert_status_flags.h"
15 #include "net/base/net_errors.h" 15 #include "net/base/net_errors.h"
16 #include "net/base/ssl_info.h" 16 #include "net/base/ssl_info.h"
17 17
18 SSLErrorInfo::SSLErrorInfo(const std::wstring& title, 18 SSLErrorInfo::SSLErrorInfo(const string16& title,
19 const std::wstring& details, 19 const string16& details,
20 const std::wstring& short_description, 20 const string16& short_description,
21 const std::vector<std::wstring>& extra_info) 21 const std::vector<string16>& extra_info)
22 : title_(title), 22 : title_(title),
23 details_(details), 23 details_(details),
24 short_description_(short_description), 24 short_description_(short_description),
25 extra_information_(extra_info) { 25 extra_information_(extra_info) {
26 } 26 }
27 27
28 // static 28 // static
29 SSLErrorInfo SSLErrorInfo::CreateError(ErrorType error_type, 29 SSLErrorInfo SSLErrorInfo::CreateError(ErrorType error_type,
30 net::X509Certificate* cert, 30 net::X509Certificate* cert,
31 const GURL& request_url) { 31 const GURL& request_url) {
32 std::wstring title, details, short_description; 32 string16 title, details, short_description;
33 std::vector<std::wstring> extra_info; 33 std::vector<string16> extra_info;
34 switch (error_type) { 34 switch (error_type) {
35 case CERT_COMMON_NAME_INVALID: { 35 case CERT_COMMON_NAME_INVALID: {
36 title = l10n_util::GetString(IDS_CERT_ERROR_COMMON_NAME_INVALID_TITLE); 36 title =
37 l10n_util::GetStringUTF16(IDS_CERT_ERROR_COMMON_NAME_INVALID_TITLE);
37 // If the certificate contains multiple DNS names, we choose the most 38 // If the certificate contains multiple DNS names, we choose the most
38 // representative one -- either the DNS name that's also in the subject 39 // representative one -- either the DNS name that's also in the subject
39 // field, or the first one. If this heuristic turns out to be 40 // field, or the first one. If this heuristic turns out to be
40 // inadequate, we can consider choosing the DNS name that is the 41 // inadequate, we can consider choosing the DNS name that is the
41 // "closest match" to the host name in the request URL, or listing all 42 // "closest match" to the host name in the request URL, or listing all
42 // the DNS names with an HTML <ul>. 43 // the DNS names with an HTML <ul>.
43 std::vector<std::string> dns_names; 44 std::vector<std::string> dns_names;
44 cert->GetDNSNames(&dns_names); 45 cert->GetDNSNames(&dns_names);
45 DCHECK(!dns_names.empty()); 46 DCHECK(!dns_names.empty());
46 size_t i = 0; 47 size_t i = 0;
47 for (; i < dns_names.size(); ++i) { 48 for (; i < dns_names.size(); ++i) {
48 if (dns_names[i] == cert->subject().common_name) 49 if (dns_names[i] == cert->subject().common_name)
49 break; 50 break;
50 } 51 }
51 if (i == dns_names.size()) 52 if (i == dns_names.size())
52 i = 0; 53 i = 0;
53 details = 54 details =
54 l10n_util::GetStringF(IDS_CERT_ERROR_COMMON_NAME_INVALID_DETAILS, 55 l10n_util::GetStringFUTF16(IDS_CERT_ERROR_COMMON_NAME_INVALID_DETAILS,
55 UTF8ToWide(request_url.host()), 56 UTF8ToUTF16(request_url.host()),
56 UTF8ToWide(dns_names[i]), 57 UTF8ToUTF16(dns_names[i]),
57 UTF8ToWide(request_url.host())); 58 UTF8ToUTF16(request_url.host()));
58 short_description = 59 short_description = l10n_util::GetStringUTF16(
59 l10n_util::GetString(IDS_CERT_ERROR_COMMON_NAME_INVALID_DESCRIPTION); 60 IDS_CERT_ERROR_COMMON_NAME_INVALID_DESCRIPTION);
60 extra_info.push_back( 61 extra_info.push_back(
61 l10n_util::GetString(IDS_CERT_ERROR_EXTRA_INFO_1)); 62 l10n_util::GetStringUTF16(IDS_CERT_ERROR_EXTRA_INFO_1));
62 extra_info.push_back( 63 extra_info.push_back(
63 l10n_util::GetStringF( 64 l10n_util::GetStringFUTF16(
64 IDS_CERT_ERROR_COMMON_NAME_INVALID_EXTRA_INFO_2, 65 IDS_CERT_ERROR_COMMON_NAME_INVALID_EXTRA_INFO_2,
65 UTF8ToWide(cert->subject().common_name), 66 UTF8ToUTF16(cert->subject().common_name),
66 UTF8ToWide(request_url.host()))); 67 UTF8ToUTF16(request_url.host())));
67 break; 68 break;
68 } 69 }
69 case CERT_DATE_INVALID: 70 case CERT_DATE_INVALID:
70 extra_info.push_back( 71 extra_info.push_back(
71 l10n_util::GetString(IDS_CERT_ERROR_EXTRA_INFO_1)); 72 l10n_util::GetStringUTF16(IDS_CERT_ERROR_EXTRA_INFO_1));
72 if (cert->HasExpired()) { 73 if (cert->HasExpired()) {
73 title = l10n_util::GetString(IDS_CERT_ERROR_EXPIRED_TITLE); 74 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_EXPIRED_TITLE);
74 details = l10n_util::GetStringF(IDS_CERT_ERROR_EXPIRED_DETAILS, 75 details = l10n_util::GetStringFUTF16(IDS_CERT_ERROR_EXPIRED_DETAILS,
75 UTF8ToWide(request_url.host()), 76 UTF8ToUTF16(request_url.host()),
76 UTF8ToWide(request_url.host())); 77 UTF8ToUTF16(request_url.host()));
77 short_description = 78 short_description =
78 l10n_util::GetString(IDS_CERT_ERROR_EXPIRED_DESCRIPTION); 79 l10n_util::GetStringUTF16(IDS_CERT_ERROR_EXPIRED_DESCRIPTION);
79 extra_info.push_back( 80 extra_info.push_back(l10n_util::GetStringUTF16(
80 l10n_util::GetString(IDS_CERT_ERROR_EXPIRED_DETAILS_EXTRA_INFO_2)); 81 IDS_CERT_ERROR_EXPIRED_DETAILS_EXTRA_INFO_2));
81 } else { 82 } else {
82 // Then it must be not yet valid. We don't check that it is not yet 83 // Then it must be not yet valid. We don't check that it is not yet
83 // valid as there is still a very unlikely chance that the cert might 84 // valid as there is still a very unlikely chance that the cert might
84 // have become valid since the error occurred. 85 // have become valid since the error occurred.
85 title = l10n_util::GetString(IDS_CERT_ERROR_NOT_YET_VALID_TITLE); 86 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_NOT_YET_VALID_TITLE);
86 details = l10n_util::GetStringF(IDS_CERT_ERROR_NOT_YET_VALID_DETAILS, 87 details = l10n_util::GetStringFUTF16(
87 UTF8ToWide(request_url.host()), 88 IDS_CERT_ERROR_NOT_YET_VALID_DETAILS,
88 UTF8ToWide(request_url.host())); 89 UTF8ToUTF16(request_url.host()),
90 UTF8ToUTF16(request_url.host()));
89 short_description = 91 short_description =
90 l10n_util::GetString(IDS_CERT_ERROR_NOT_YET_VALID_DESCRIPTION); 92 l10n_util::GetStringUTF16(IDS_CERT_ERROR_NOT_YET_VALID_DESCRIPTION);
91 extra_info.push_back( 93 extra_info.push_back(
92 l10n_util::GetString( 94 l10n_util::GetStringUTF16(
93 IDS_CERT_ERROR_NOT_YET_VALID_DETAILS_EXTRA_INFO_2)); 95 IDS_CERT_ERROR_NOT_YET_VALID_DETAILS_EXTRA_INFO_2));
94 } 96 }
95 break; 97 break;
96 case CERT_AUTHORITY_INVALID: 98 case CERT_AUTHORITY_INVALID:
97 title = l10n_util::GetString(IDS_CERT_ERROR_AUTHORITY_INVALID_TITLE); 99 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_AUTHORITY_INVALID_TITLE);
98 details = l10n_util::GetStringF(IDS_CERT_ERROR_AUTHORITY_INVALID_DETAILS, 100 details = l10n_util::GetStringFUTF16(
99 UTF8ToWide(request_url.host())); 101 IDS_CERT_ERROR_AUTHORITY_INVALID_DETAILS,
100 short_description = 102 UTF8ToUTF16(request_url.host()));
101 l10n_util::GetString(IDS_CERT_ERROR_AUTHORITY_INVALID_DESCRIPTION); 103 short_description = l10n_util::GetStringUTF16(
104 IDS_CERT_ERROR_AUTHORITY_INVALID_DESCRIPTION);
102 extra_info.push_back( 105 extra_info.push_back(
103 l10n_util::GetString(IDS_CERT_ERROR_EXTRA_INFO_1)); 106 l10n_util::GetStringUTF16(IDS_CERT_ERROR_EXTRA_INFO_1));
104 extra_info.push_back( 107 extra_info.push_back(l10n_util::GetStringFUTF16(
105 l10n_util::GetStringF(IDS_CERT_ERROR_AUTHORITY_INVALID_EXTRA_INFO_2, 108 IDS_CERT_ERROR_AUTHORITY_INVALID_EXTRA_INFO_2,
106 UTF8ToWide(request_url.host()), 109 UTF8ToUTF16(request_url.host()),
107 UTF8ToWide(request_url.host()))); 110 UTF8ToUTF16(request_url.host())));
108 extra_info.push_back( 111 extra_info.push_back(l10n_util::GetStringUTF16(
109 l10n_util::GetString(IDS_CERT_ERROR_AUTHORITY_INVALID_EXTRA_INFO_3)); 112 IDS_CERT_ERROR_AUTHORITY_INVALID_EXTRA_INFO_3));
110 break; 113 break;
111 case CERT_CONTAINS_ERRORS: 114 case CERT_CONTAINS_ERRORS:
112 title = l10n_util::GetString(IDS_CERT_ERROR_CONTAINS_ERRORS_TITLE); 115 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_CONTAINS_ERRORS_TITLE);
113 details = l10n_util::GetStringF(IDS_CERT_ERROR_CONTAINS_ERRORS_DETAILS, 116 details = l10n_util::GetStringFUTF16(
114 UTF8ToWide(request_url.host())); 117 IDS_CERT_ERROR_CONTAINS_ERRORS_DETAILS,
118 UTF8ToUTF16(request_url.host()));
115 short_description = 119 short_description =
116 l10n_util::GetString(IDS_CERT_ERROR_CONTAINS_ERRORS_DESCRIPTION); 120 l10n_util::GetStringUTF16(IDS_CERT_ERROR_CONTAINS_ERRORS_DESCRIPTION);
117 extra_info.push_back( 121 extra_info.push_back(
118 l10n_util::GetStringF(IDS_CERT_ERROR_EXTRA_INFO_1, 122 l10n_util::GetStringFUTF16(IDS_CERT_ERROR_EXTRA_INFO_1,
119 UTF8ToWide(request_url.host()))); 123 UTF8ToUTF16(request_url.host())));
120 extra_info.push_back( 124 extra_info.push_back(l10n_util::GetStringUTF16(
121 l10n_util::GetString(IDS_CERT_ERROR_CONTAINS_ERRORS_EXTRA_INFO_2)); 125 IDS_CERT_ERROR_CONTAINS_ERRORS_EXTRA_INFO_2));
122 break; 126 break;
123 case CERT_NO_REVOCATION_MECHANISM: 127 case CERT_NO_REVOCATION_MECHANISM:
124 title = 128 title = l10n_util::GetStringUTF16(
125 l10n_util::GetString(IDS_CERT_ERROR_NO_REVOCATION_MECHANISM_TITLE); 129 IDS_CERT_ERROR_NO_REVOCATION_MECHANISM_TITLE);
126 details = 130 details = l10n_util::GetStringUTF16(
127 l10n_util::GetString(IDS_CERT_ERROR_NO_REVOCATION_MECHANISM_DETAILS); 131 IDS_CERT_ERROR_NO_REVOCATION_MECHANISM_DETAILS);
128 short_description = l10n_util::GetString( 132 short_description = l10n_util::GetStringUTF16(
129 IDS_CERT_ERROR_NO_REVOCATION_MECHANISM_DESCRIPTION); 133 IDS_CERT_ERROR_NO_REVOCATION_MECHANISM_DESCRIPTION);
130 break; 134 break;
131 case CERT_UNABLE_TO_CHECK_REVOCATION: 135 case CERT_UNABLE_TO_CHECK_REVOCATION:
132 title = 136 title = l10n_util::GetStringUTF16(
133 l10n_util::GetString(IDS_CERT_ERROR_UNABLE_TO_CHECK_REVOCATION_TITLE); 137 IDS_CERT_ERROR_UNABLE_TO_CHECK_REVOCATION_TITLE);
134 details = l10n_util::GetString( 138 details = l10n_util::GetStringUTF16(
135 IDS_CERT_ERROR_UNABLE_TO_CHECK_REVOCATION_DETAILS); 139 IDS_CERT_ERROR_UNABLE_TO_CHECK_REVOCATION_DETAILS);
136 short_description = l10n_util::GetString( 140 short_description = l10n_util::GetStringUTF16(
137 IDS_CERT_ERROR_UNABLE_TO_CHECK_REVOCATION_DESCRIPTION); 141 IDS_CERT_ERROR_UNABLE_TO_CHECK_REVOCATION_DESCRIPTION);
138 break; 142 break;
139 case CERT_REVOKED: 143 case CERT_REVOKED:
140 title = l10n_util::GetString(IDS_CERT_ERROR_REVOKED_CERT_TITLE); 144 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_REVOKED_CERT_TITLE);
141 details = l10n_util::GetStringF(IDS_CERT_ERROR_REVOKED_CERT_DETAILS, 145 details = l10n_util::GetStringFUTF16(IDS_CERT_ERROR_REVOKED_CERT_DETAILS,
142 UTF8ToWide(request_url.host())); 146 UTF8ToUTF16(request_url.host()));
143 short_description = 147 short_description =
144 l10n_util::GetString(IDS_CERT_ERROR_REVOKED_CERT_DESCRIPTION); 148 l10n_util::GetStringUTF16(IDS_CERT_ERROR_REVOKED_CERT_DESCRIPTION);
145 extra_info.push_back( 149 extra_info.push_back(
146 l10n_util::GetString(IDS_CERT_ERROR_EXTRA_INFO_1)); 150 l10n_util::GetStringUTF16(IDS_CERT_ERROR_EXTRA_INFO_1));
147 extra_info.push_back( 151 extra_info.push_back(
148 l10n_util::GetString(IDS_CERT_ERROR_REVOKED_CERT_EXTRA_INFO_2)); 152 l10n_util::GetStringUTF16(IDS_CERT_ERROR_REVOKED_CERT_EXTRA_INFO_2));
149 break; 153 break;
150 case CERT_INVALID: 154 case CERT_INVALID:
151 title = l10n_util::GetString(IDS_CERT_ERROR_INVALID_CERT_TITLE); 155 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_INVALID_CERT_TITLE);
152 details = l10n_util::GetString(IDS_CERT_ERROR_INVALID_CERT_DETAILS); 156 details = l10n_util::GetStringUTF16(IDS_CERT_ERROR_INVALID_CERT_DETAILS);
153 short_description = 157 short_description =
154 l10n_util::GetString(IDS_CERT_ERROR_INVALID_CERT_DESCRIPTION); 158 l10n_util::GetStringUTF16(IDS_CERT_ERROR_INVALID_CERT_DESCRIPTION);
155 break; 159 break;
156 case CERT_WEAK_SIGNATURE_ALGORITHM: 160 case CERT_WEAK_SIGNATURE_ALGORITHM:
157 title = 161 title = l10n_util::GetStringUTF16(
158 l10n_util::GetString(IDS_CERT_ERROR_WEAK_SIGNATURE_ALGORITHM_TITLE); 162 IDS_CERT_ERROR_WEAK_SIGNATURE_ALGORITHM_TITLE);
159 details = l10n_util::GetStringF( 163 details = l10n_util::GetStringFUTF16(
160 IDS_CERT_ERROR_WEAK_SIGNATURE_ALGORITHM_DETAILS, 164 IDS_CERT_ERROR_WEAK_SIGNATURE_ALGORITHM_DETAILS,
161 UTF8ToWide(request_url.host())); 165 UTF8ToUTF16(request_url.host()));
162 short_description = l10n_util::GetString( 166 short_description = l10n_util::GetStringUTF16(
163 IDS_CERT_ERROR_WEAK_SIGNATURE_ALGORITHM_DESCRIPTION); 167 IDS_CERT_ERROR_WEAK_SIGNATURE_ALGORITHM_DESCRIPTION);
164 extra_info.push_back( 168 extra_info.push_back(
165 l10n_util::GetString(IDS_CERT_ERROR_EXTRA_INFO_1)); 169 l10n_util::GetStringUTF16(IDS_CERT_ERROR_EXTRA_INFO_1));
166 extra_info.push_back( 170 extra_info.push_back(
167 l10n_util::GetString( 171 l10n_util::GetStringUTF16(
168 IDS_CERT_ERROR_WEAK_SIGNATURE_ALGORITHM_EXTRA_INFO_2)); 172 IDS_CERT_ERROR_WEAK_SIGNATURE_ALGORITHM_EXTRA_INFO_2));
169 break; 173 break;
170 case CERT_NOT_IN_DNS: 174 case CERT_NOT_IN_DNS:
171 title = l10n_util::GetString(IDS_CERT_ERROR_NOT_IN_DNS_TITLE); 175 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_NOT_IN_DNS_TITLE);
172 details = l10n_util::GetString(IDS_CERT_ERROR_NOT_IN_DNS_DETAILS); 176 details = l10n_util::GetStringUTF16(IDS_CERT_ERROR_NOT_IN_DNS_DETAILS);
173 short_description = l10n_util::GetString( 177 short_description = l10n_util::GetStringUTF16(
174 IDS_CERT_ERROR_NOT_IN_DNS_DESCRIPTION); 178 IDS_CERT_ERROR_NOT_IN_DNS_DESCRIPTION);
175 extra_info.push_back( 179 extra_info.push_back(
176 l10n_util::GetString(IDS_CERT_ERROR_NOT_IN_DNS_EXTRA_INFO)); 180 l10n_util::GetStringUTF16(IDS_CERT_ERROR_NOT_IN_DNS_EXTRA_INFO));
177 break; 181 break;
178 case UNKNOWN: 182 case UNKNOWN:
179 title = l10n_util::GetString(IDS_CERT_ERROR_UNKNOWN_ERROR_TITLE); 183 title = l10n_util::GetStringUTF16(IDS_CERT_ERROR_UNKNOWN_ERROR_TITLE);
180 details = l10n_util::GetString(IDS_CERT_ERROR_UNKNOWN_ERROR_DETAILS); 184 details = l10n_util::GetStringUTF16(IDS_CERT_ERROR_UNKNOWN_ERROR_DETAILS);
181 short_description = 185 short_description =
182 l10n_util::GetString(IDS_CERT_ERROR_UNKNOWN_ERROR_DESCRIPTION); 186 l10n_util::GetStringUTF16(IDS_CERT_ERROR_UNKNOWN_ERROR_DESCRIPTION);
183 break; 187 break;
184 default: 188 default:
185 NOTREACHED(); 189 NOTREACHED();
186 } 190 }
187 return SSLErrorInfo(title, details, short_description, extra_info); 191 return SSLErrorInfo(title, details, short_description, extra_info);
188 } 192 }
189 193
190 SSLErrorInfo::~SSLErrorInfo() { 194 SSLErrorInfo::~SSLErrorInfo() {
191 } 195 }
192 196
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 if (!cert.get()) { 259 if (!cert.get()) {
256 bool r = CertStore::GetInstance()->RetrieveCert(cert_id, &cert); 260 bool r = CertStore::GetInstance()->RetrieveCert(cert_id, &cert);
257 DCHECK(r); 261 DCHECK(r);
258 } 262 }
259 if (errors) 263 if (errors)
260 errors->push_back(SSLErrorInfo::CreateError(kErrorTypes[i], cert, url)); 264 errors->push_back(SSLErrorInfo::CreateError(kErrorTypes[i], cert, url));
261 } 265 }
262 } 266 }
263 return count; 267 return count;
264 } 268 }
OLDNEW
« no previous file with comments | « chrome/browser/ssl/ssl_error_info.h ('k') | chrome/browser/tab_contents/tab_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698