Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 5958007: keyboard: Don't clear Control on Control-Alt-Backspace. (Closed)

Created:
10 years ago by Daniel Erat
Modified:
9 years, 7 months ago
Reviewers:
Yusuke Sato, satorux1
CC:
chromium-os-reviews_chromium.org, msb+crosoverlay_chromium.org, Daniel Erat, adlr+crosoverlay_chromium.org, anush
Visibility:
Public.

Description

keyboard: Don't clear Control on Control-Alt-Backspace. I think I was overzealous in clearing the modifier keys here; we should be clearing Alt (as it's used to convert the Backspace into Delete), but not Control. This is needed for the user to be able to type Ctrl-Alt-Shift-Backspace to produce Ctrl-Shift-Delete to bring up the "Clear Browsing Data" dialog. I still need to make a theme change to delete GtkTextView's hardcoded Ctrl-Shift-Delete "delete to the end of the paragraph" binding; until then, this shortcut won't work when the focus is in the omnibox. (Yes, this is a difficult-to-type combination and hitting Ctrl-Alt-Backspace still makes me cringe even though X isn't configured to intercept it. Seems worthwhile to stay consistent with other platforms as long as we can, though.) Change-Id: I68540fdc270df2a13e3487f3bdc8866d2d0a6fea BUG=chromium-os:8986 TEST=built and tried it Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d972aca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M x11-misc/xkeyboard-config/files/xkeyboard-config-1.7-backspace-and-arrow-keys.patch View 2 chunks +2 lines, -2 lines 0 comments Download
A + x11-misc/xkeyboard-config/xkeyboard-config-1.7-r15.ebuild View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Daniel Erat
10 years ago (2010-12-23 18:37:04 UTC) #1
Yusuke Sato
10 years ago (2010-12-24 00:54:36 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698