Don't send frame update messages for non-browser RWHVs

Don't send frame update messages for non-browser RWHVs

BUG=35141
TEST=Trigger an autocomplete popup; watch the renderer not crash.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38520

[rohitrao (ping after 24h), 2010-02-09 21:56:50]

LGTM

I'm still interested in learning how the rest of the code avoids sending
messages to widgets that aren't views.  I'll dig when I have time and report
back.

http://codereview.chromium.org/594015/diff/1/2
File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/594015/diff/1/2#newcode129
chrome/browser/renderer_host/render_widget_host_view_mac.mm:129:
[parent_host_view->GetNativeView() addSubview:cocoa_view_];
Why did this move?

[stuartmorgan, 2010-02-09 22:05:00]

On 2010/02/09 21:56:50, rohitrao wrote:
> I'm still interested in learning how the rest of the code avoids sending
> messages to widgets that aren't views.  I'll dig when I have time and report
> back.

I think it's just that the triggering things would never happen in a non-browser
RWHV. The problem here was that I wired it directly to an intermediate-level
native view, which is used in both cases.

> Why did this move?

Because that line moves the view into the window; if we haven't given the view
enough information to know it's a popup before we do that, there's nothing it
can check.