Don't send frame update messages for non-browser RWHVs

chrome/browser/renderer_host/render_widget_host_view_mac.mm

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <QuartzCore/CAOpenGLLayer.h>
 
 #include "chrome/browser/renderer_host/render_widget_host_view_mac.h"
 
 #import "base/chrome_application_mac.h"
 #include "base/histogram.h"
@@ skipping 106 matching lines @@
 RenderWidgetHostViewMac::~RenderWidgetHostViewMac() {
   [im_attributes_ release];
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // RenderWidgetHostViewMac, RenderWidgetHostView implementation:
 
 void RenderWidgetHostViewMac::InitAsPopup(
     RenderWidgetHostView* parent_host_view,
     const gfx::Rect& pos) {
-  [parent_host_view->GetNativeView() addSubview:cocoa_view_];
   [cocoa_view_ setCloseOnDeactivate:YES];
   [cocoa_view_ setCanBeKeyView:activatable_ ? YES : NO];
+  [parent_host_view->GetNativeView() addSubview:cocoa_view_];

[rohitrao (ping after 24h), 2010/02/09 21:56:50]

Why did this move?

 
   // TODO(avi):Why the hell are these screen coordinates? The Windows code calls
   // ::MoveWindow() which indicates they should be local, but when running it I
   // get global ones instead!
 
   NSPoint global_origin = NSPointFromCGPoint(pos.origin().ToCGPoint());
   global_origin.y = [[[cocoa_view_ window] screen] frame].size.height -
       pos.height() - global_origin.y;
   NSPoint window_origin =
       [[cocoa_view_ window] convertScreenToBase:global_origin];
@@ skipping 1397 matching lines @@
     renderWidgetHostView_->render_widget_host_->ImeConfirmComposition(
         UTF8ToUTF16([im_text UTF8String]));
   }
   renderWidgetHostView_->im_composing_ = false;
 }
 
 - (void)viewDidMoveToWindow {
   // If we move into a new window, refresh the frame information. We don't need
   // to do it if it was the same window as it used to be in, since that case
   // is covered by DidBecomeSelected.
-  NSWindow* newWindow = [self window];
-  // Pointer comparison only, since we don't know if lastWindow_ is still valid.
-  if (newWindow && (newWindow != lastWindow_)) {
-    lastWindow_ = newWindow;
-    renderWidgetHostView_->WindowFrameChanged();
+  // We only want to do this for real browser views, not popups.
+  if (canBeKeyView_) {
+    NSWindow* newWindow = [self window];
+    // Pointer comparison only, since we don't know if lastWindow_ is still
+    // valid.
+    if (newWindow && (newWindow != lastWindow_)) {
+      lastWindow_ = newWindow;
+      renderWidgetHostView_->WindowFrameChanged();
+    }
   }
 }
 
 @end