Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Issue 593037: Remove the temporary scaffolding stubs. (Closed)

Created:
10 years, 10 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove the temporary scaffolding stubs. They have served they purpose well, but now it's time to retire. It's one of the things that draggen in the bad dependency of chrome/common on chrome/browser, and is sufficiently small now to stub things out individually. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38639

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -278 lines) Patch
M chrome/PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_provider_mac.mm View 1 2 chunks +41 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_drag_data.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/browser.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/browser_list_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/browser_list_stub.cc View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/browser/browser_list_win.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/cocoa/browser_window_cocoa.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/cocoa/font_language_settings_controller.mm View 2 chunks +7 lines, -0 lines 0 comments Download
A chrome/browser/dock_info_mac.cc View 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/browser/jankometer_mac.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 chunk +2 lines, -4 lines 0 comments Download
A chrome/browser/printing/print_job_linux.cc View 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/browser/printing/print_job_manager_linux.cc View 1 chunk +41 lines, -0 lines 0 comments Download
A chrome/browser/printing/print_view_manager_linux.cc View 1 chunk +58 lines, -0 lines 0 comments Download
A chrome/browser/printing/printer_query_linux.cc View 1 chunk +58 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_browser.gypi View 9 chunks +22 lines, -6 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +0 lines, -13 lines 0 comments Download
D chrome/common/temp_scaffolding_stubs.h View 1 chunk +0 lines, -119 lines 0 comments Download
D chrome/common/temp_scaffolding_stubs.cc View 1 chunk +0 lines, -95 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
10 years, 10 months ago (2010-02-10 17:19:04 UTC) #1
Evan Martin
Yes! LGTM http://codereview.chromium.org/593037/diff/1/4 File chrome/browser/automation/automation_provider_mac.mm (right): http://codereview.chromium.org/593037/diff/1/4#newcode71 chrome/browser/automation/automation_provider_mac.mm:71: bool* success, std::wstring* text) { 80 cols ...
10 years, 10 months ago (2010-02-10 17:23:34 UTC) #2
pink (ping after 24hrs)
LGTM http://codereview.chromium.org/593037/diff/1/5 File chrome/browser/bookmarks/bookmark_drag_data.h (right): http://codereview.chromium.org/593037/diff/1/5#newcode15 chrome/browser/bookmarks/bookmark_drag_data.h:15: // TODO(port): Port this file. can we remove ...
10 years, 10 months ago (2010-02-10 17:42:55 UTC) #3
Paweł Hajdan Jr.
pink, Evan: most done, one comment added tony/maruel: waiting for LGTM from at least one ...
10 years, 10 months ago (2010-02-10 18:03:10 UTC) #4
M-A Ruel
10 years, 10 months ago (2010-02-10 18:31:49 UTC) #5
rubberstamp lgtm, for the linux printing part, I'm not that intimate with it, as
long "as it works (tm)"

Powered by Google App Engine
This is Rietveld 408576698