Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: chrome/PRESUBMIT.py

Issue 593037: Remove the temporary scaffolding stubs. (Closed)
Patch Set: fixes Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/app_controller_mac.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Makes sure that the chrome/ code is cpplint clean.""" 5 """Makes sure that the chrome/ code is cpplint clean."""
6 6
7 INCLUDE_CPP_FILES_ONLY = ( 7 INCLUDE_CPP_FILES_ONLY = (
8 r'.*\.cc$', r'.*\.h$' 8 r'.*\.cc$', r'.*\.h$'
9 ) 9 )
10 10
(...skipping 18 matching lines...) Expand all
29 # Mozilla code 29 # Mozilla code
30 r'mork_reader\.h$', 30 r'mork_reader\.h$',
31 r'mork_reader\.cc$', 31 r'mork_reader\.cc$',
32 r'nss_decryptor_linux\.cc$', 32 r'nss_decryptor_linux\.cc$',
33 # Has safe printf usage that cpplint complains about 33 # Has safe printf usage that cpplint complains about
34 r'safe_browsing_util\.cc$', 34 r'safe_browsing_util\.cc$',
35 # Too much math on one line? 35 # Too much math on one line?
36 r'bloom_filter\.cc$', 36 r'bloom_filter\.cc$',
37 # Bogus ifdef tricks 37 # Bogus ifdef tricks
38 r'renderer_webkitclient_impl\.cc$', 38 r'renderer_webkitclient_impl\.cc$',
39 r'temp_scaffolding_stubs\.h$',
40 # Lines > 100 chars 39 # Lines > 100 chars
41 r'gcapi\.cc$', 40 r'gcapi\.cc$',
42 ) 41 )
43 42
44 def CheckChangeOnUpload(input_api, output_api): 43 def CheckChangeOnUpload(input_api, output_api):
45 results = [] 44 results = []
46 black_list = input_api.DEFAULT_BLACK_LIST + EXCLUDE 45 black_list = input_api.DEFAULT_BLACK_LIST + EXCLUDE
47 sources = lambda x: input_api.FilterSourceFile( 46 sources = lambda x: input_api.FilterSourceFile(
48 x, white_list=INCLUDE_CPP_FILES_ONLY, black_list=black_list) 47 x, white_list=INCLUDE_CPP_FILES_ONLY, black_list=black_list)
49 results.extend(input_api.canned_checks.CheckChangeLintsClean( 48 results.extend(input_api.canned_checks.CheckChangeLintsClean(
50 input_api, output_api, sources)) 49 input_api, output_api, sources))
51 return results 50 return results
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/app_controller_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698