Issue 5918003: Bugfixes for recent PluginGroup refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5918003: Bugfixes for recent PluginGroup refactoring. (Closed)

Created:
10 years ago by Jakob Kummerow

Modified:
9 years, 6 months ago

Reviewers:
Bernhard Bauer, danno

CC:
chromium-reviews, jam, Paweł Hajdan Jr., darin-cc_chromium.org, stuartmorgan+watch_chromium.org, brettw-cc_chromium.org, pastarmovj

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Bugfixes for recent PluginGroup refactoring. BUG=66505 TEST=test_shell_tests: PluginGroupTest.*; manual: check that issues reported and screenshotted in bug 66505 no longer occur Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69813

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+95 lines, -36 lines)			Patch
M	base/version.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	base/version.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/plugin_group.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/plugin_group.cc	View	3 chunks	+8 lines, -8 lines	0 comments	Download
M	webkit/glue/plugins/plugin_group_unittest.cc	View	4 chunks	+64 lines, -23 lines	0 comments	Download
M	webkit/glue/plugins/plugin_list.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/glue/plugins/webplugininfo.h	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	webkit/glue/plugins/webplugininfo.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

Since CL 5783005 depends on CL 5699005, which is somewhat stalled pending a decision on ...

10 years ago (2010-12-16 12:52:51 UTC) #1

LGTM