chrome/browser/extensions/extension_proxy_api.cc - Issue 5915004: Introduce incognito preference settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_proxy_api.cc

Issue 5915004: Introduce incognito preference settings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_proxy_api.cc

diff --git a/chrome/browser/extensions/extension_proxy_api.cc b/chrome/browser/extensions/extension_proxy_api.cc

index 9bc33cbf5681cc01b57efc1299fe72db7803f1b1..86621d9ed63ff93b31e589fa7c48453d53a18264 100644

--- a/chrome/browser/extensions/extension_proxy_api.cc

+++ b/chrome/browser/extensions/extension_proxy_api.cc

@@ -159,6 +159,8 @@ bool UseCustomProxySettingsFunction::ApplyProxyRules(

void UseCustomProxySettingsFunction::SendNotification(const char* pref_path,

Value* pref_value) {

+ const bool incognito = false;

profile()->GetExtensionService()->extension_prefs()

- ->SetExtensionControlledPref(extension_id(), pref_path, pref_value);

+ ->SetExtensionControlledPref(extension_id(), pref_path, incognito,

danno 2010/12/22 10:48:21 Why not pass false directly at the call site?

battre 2010/12/22 18:34:53 If one of four parameters is a plain "false", I co

+ pref_value);

}