Introduce incognito preference settings.

chrome/browser/extensions/extension_proxy_api.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_proxy_api.h"
 
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/values.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 141 matching lines @@
       }
     }
   }
 
   SendNotification(prefs::kProxyServer, Value::CreateStringValue(proxy_pref));
   return true;
 }
 
 void UseCustomProxySettingsFunction::SendNotification(const char* pref_path,
                                                       Value* pref_value) {
+  const bool incognito = false;
   profile()->GetExtensionService()->extension_prefs()
-      ->SetExtensionControlledPref(extension_id(), pref_path, pref_value);
+      ->SetExtensionControlledPref(extension_id(), pref_path, incognito,

[danno, 2010/12/22 10:48:21]

Why not pass false directly at the call site?

[battre, 2010/12/22 18:34:53]

If one of four parameters is a plain "false", I consider this bad style because
you cannot just grasp the parameter list without looking up the function
declaration.

+                                   pref_value);
 }