chrome/browser/chromeos/input_method/input_method_util.cc - Issue 5904003: Support US Colemak keyboard layout (Chrome part)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_util.cc

Issue 5904003: Support US Colemak keyboard layout (Chrome part) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review fixes Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/input_method/input_method_util.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_util.cc b/chrome/browser/chromeos/input_method/input_method_util.cc

index c48f26b311b0bb8b55f64996c76144233fc54623..67fcb5bb55da26f780305e300805b197a013e10f 100644

--- a/chrome/browser/chromeos/input_method/input_method_util.cc

+++ b/chrome/browser/chromeos/input_method/input_method_util.cc

@@ -64,6 +64,8 @@ const struct InputMethodIdToKeyboardOverlayId {

{ "xkb:us:intl:eng", "en_US" },

{ "xkb:us:altgr-intl:eng", "en_US" },

{ "xkb:us:dvorak:eng", "en_US_dvorak" },

+ // TODO(mazda): Add keyboard overlay definition for US Colemak.

+ { "xkb:us:colemak:eng", "en_US" },

{ "hangul", "ko" },

{ "pinyin", "zh_CN" },

{ "m17n:ar:kbd", "ar" },

@@ -278,6 +280,7 @@ const struct EnglishToResouceId {

{ "Serbia", IDS_STATUSBAR_LAYOUT_SERBIA },

{ "Czechia", IDS_STATUSBAR_LAYOUT_CZECHIA },

{ "USA - Dvorak", IDS_STATUSBAR_LAYOUT_USA_DVORAK },

+ { "USA - Colemak", IDS_STATUSBAR_LAYOUT_USA_COLEMAK },

{ "Romania", IDS_STATUSBAR_LAYOUT_ROMANIA },

{ "USA", IDS_STATUSBAR_LAYOUT_USA },

{ "USA - International (AltGr dead keys)",