Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: chrome/browser/chromeos/input_method/input_method_util_unittest.cc

Issue 5904003: Support US Colemak keyboard layout (Chrome part) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review fixes Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_util_unittest.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_util_unittest.cc b/chrome/browser/chromeos/input_method/input_method_util_unittest.cc
index d89690cf32a1c9caa810b616c273407caee5f42a..7d4c2464e8b8ffcbd12615409e5bc99198b9a790 100644
--- a/chrome/browser/chromeos/input_method/input_method_util_unittest.cc
+++ b/chrome/browser/chromeos/input_method/input_method_util_unittest.cc
@@ -134,6 +134,7 @@ TEST(InputMethodUtilTest, GetKeyboardLayoutName) {
EXPECT_EQ("ua", GetKeyboardLayoutName("xkb:ua::ukr"));
EXPECT_EQ("us", GetKeyboardLayoutName("xkb:us::eng"));
EXPECT_EQ("us", GetKeyboardLayoutName("xkb:us:dvorak:eng"));
+ EXPECT_EQ("us", GetKeyboardLayoutName("xkb:us:colemak:eng"));
}
TEST(InputMethodUtilTest, GetKeyboardOverlayId) {
@@ -171,6 +172,8 @@ TEST(InputMethodUtilTest, GetKeyboardOverlayId) {
EXPECT_EQ("en_US", GetKeyboardOverlayId("xkb:us:intl:eng"));
EXPECT_EQ("en_US", GetKeyboardOverlayId("xkb:us:altgr-intl:eng"));
EXPECT_EQ("en_US_dvorak", GetKeyboardOverlayId("xkb:us:dvorak:eng"));
+ // TODO(mazda): Add keyboard overlay definition for US Colemak.
+ EXPECT_EQ("en_US", GetKeyboardOverlayId("xkb:us:colemak:eng"));
EXPECT_EQ("ko", GetKeyboardOverlayId("hangul"));
EXPECT_EQ("zh_CN", GetKeyboardOverlayId("pinyin"));
EXPECT_EQ("ar", GetKeyboardOverlayId("m17n:ar:kbd"));
« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_util.cc ('k') | chrome/browser/chromeos/status/input_method_menu.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698