Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 5904003: Support US Colemak keyboard layout (Chrome part) (Closed)

Created:
10 years ago by Yusuke Sato
Modified:
9 years, 7 months ago
Reviewers:
mazda
CC:
chromium-reviews, davemoore+watch_chromium.org, Daniel Erat, satorux1, Paweł Hajdan Jr.
Visibility:
Public.

Description

Support US Colemak keyboard layout (Chrome part) BUG=chromium-os:10275 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69383

Patch Set 1 #

Patch Set 2 : review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yusuke Sato
10 years ago (2010-12-16 06:26:40 UTC) #1
mazda
Could you also modify input_method_util_unittest.cc?
10 years ago (2010-12-16 07:03:59 UTC) #2
Yusuke Sato
Done. PTAL.
10 years ago (2010-12-16 07:14:12 UTC) #3
mazda
10 years ago (2010-12-16 07:16:16 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698