Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: chrome/browser/chromeos/login/new_user_view.cc

Issue 5839003: Fix to enable toggling accessibility using Ctrl+Alt+Z (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/new_user_view.cc
===================================================================
--- chrome/browser/chromeos/login/new_user_view.cc (revision 69334)
+++ chrome/browser/chromeos/login/new_user_view.cc (working copy)
@@ -98,7 +98,7 @@
accel_focus_user_(views::Accelerator(app::VKEY_U, false, false, true)),
accel_login_off_the_record_(
views::Accelerator(app::VKEY_B, false, false, true)),
- accel_enable_accessibility_(WizardAccessibilityHelper::GetAccelerator()),
+ accel_toggle_accessibility_(WizardAccessibilityHelper::GetAccelerator()),
delegate_(delegate),
ALLOW_THIS_IN_INITIALIZER_LIST(focus_grabber_factory_(this)),
focus_delayed_(false),
@@ -150,6 +150,7 @@
username_field_ = new UsernameField();
username_field_->set_background(new CopyBackground(this));
+ username_field_->SetAccessibleName(std::wstring(L"Username"));
Chaitanya 2010/12/15 23:19:56 I'd like to i18n the string literal "Username". Ho
xiyuan 2010/12/16 00:09:20 check out base/utf_string_conversions.h, assuming
oshima 2010/12/16 00:36:53 Just wondering, why this is not i18n? For pure asc
AddChildView(username_field_);
password_field_ = new TextfieldWithMargin(views::Textfield::STYLE_PASSWORD);
@@ -173,7 +174,7 @@
AddAccelerator(accel_focus_user_);
AddAccelerator(accel_focus_pass_);
AddAccelerator(accel_login_off_the_record_);
- AddAccelerator(accel_enable_accessibility_);
+ AddAccelerator(accel_toggle_accessibility_);
OnLocaleChanged();
@@ -196,8 +197,8 @@
password_field_->RequestFocus();
} else if (accelerator == accel_login_off_the_record_) {
delegate_->OnLoginOffTheRecord();
- } else if (accelerator == accel_enable_accessibility_) {
- WizardAccessibilityHelper::GetInstance()->EnableAccessibility(this);
+ } else if (accelerator == accel_toggle_accessibility_) {
+ WizardAccessibilityHelper::GetInstance()->ToggleAccessibility(this);
} else {
return false;
}

Powered by Google App Engine
This is Rietveld 408576698