Fix to enable toggling accessibility using Ctrl+Alt+Z

chrome/browser/chromeos/login/new_user_view.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/new_user_view.h"
 
 #include <signal.h>
 #include <sys/types.h>
 
 #include <algorithm>
@@ skipping 80 matching lines @@
       splitter_down1_(NULL),
       splitter_down2_(NULL),
       sign_in_button_(NULL),
       create_account_link_(NULL),
       guest_link_(NULL),
       languages_menubutton_(NULL),
       accel_focus_pass_(views::Accelerator(app::VKEY_P, false, false, true)),
       accel_focus_user_(views::Accelerator(app::VKEY_U, false, false, true)),
       accel_login_off_the_record_(
           views::Accelerator(app::VKEY_B, false, false, true)),
-      accel_enable_accessibility_(WizardAccessibilityHelper::GetAccelerator()),
+      accel_toggle_accessibility_(WizardAccessibilityHelper::GetAccelerator()),
       delegate_(delegate),
       ALLOW_THIS_IN_INITIALIZER_LIST(focus_grabber_factory_(this)),
       focus_delayed_(false),
       login_in_process_(false),
       need_border_(need_border),
       need_guest_link_(false),
       need_create_account_(false),
       languages_menubutton_order_(-1),
       sign_in_button_order_(-1) {
   if (need_guest_link && UserCrosSettingsProvider::cached_allow_guest())
@@ skipping 31 matching lines @@
   title_hint_label_->SetMultiLine(true);
   AddChildView(title_hint_label_);
 
   splitter_up1_ = CreateSplitter(kSplitterUp1Color);
   splitter_up2_ = CreateSplitter(kSplitterUp2Color);
   splitter_down1_ = CreateSplitter(kSplitterDown1Color);
   splitter_down2_ = CreateSplitter(kSplitterDown2Color);
 
   username_field_ = new UsernameField();
   username_field_->set_background(new CopyBackground(this));
+  username_field_->SetAccessibleName(std::wstring(L"Username"));

[Chaitanya, 2010/12/15 23:19:56]

I'd like to i18n the string literal "Username".
How can I convert std::string to std::wstring? Is there a preferred utility
function I should use?

[xiyuan, 2010/12/16 00:09:20]

check out base/utf_string_conversions.h, assuming std::string is UTF8, then you
can use UTF8ToWide,

[oshima, 2010/12/16 00:36:53]

Just wondering, why this is not i18n? For pure ascii string,
you can use ASCIIToWide.

   AddChildView(username_field_);
 
   password_field_ = new TextfieldWithMargin(views::Textfield::STYLE_PASSWORD);
   password_field_->set_background(new CopyBackground(this));
   AddChildView(password_field_);
 
   language_switch_menu_.InitLanguageMenu();
 
   RecreatePeculiarControls();
 
   AddChildView(sign_in_button_);
   if (need_create_account_) {
     InitLink(&create_account_link_);
   }
   if (need_guest_link_) {
     InitLink(&guest_link_);
   }
   AddChildView(languages_menubutton_);
 
   // Set up accelerators.
   AddAccelerator(accel_focus_user_);
   AddAccelerator(accel_focus_pass_);
   AddAccelerator(accel_login_off_the_record_);
-  AddAccelerator(accel_enable_accessibility_);
+  AddAccelerator(accel_toggle_accessibility_);
 
   OnLocaleChanged();
 
   // Controller to handle events from textfields
   username_field_->SetController(this);
   password_field_->SetController(this);
   if (!CrosLibrary::Get()->EnsureLoaded()) {
     EnableInputControls(false);
   }
 
   // The 'Sign in' button should be disabled when there is no text in the
   // username and password fields.
   sign_in_button_->SetEnabled(false);
 }
 
 bool NewUserView::AcceleratorPressed(const views::Accelerator& accelerator) {
   if (accelerator == accel_focus_user_) {
     username_field_->RequestFocus();
   } else if (accelerator == accel_focus_pass_) {
     password_field_->RequestFocus();
   } else if (accelerator == accel_login_off_the_record_) {
     delegate_->OnLoginOffTheRecord();
-  } else if (accelerator == accel_enable_accessibility_) {
-    WizardAccessibilityHelper::GetInstance()->EnableAccessibility(this);
+  } else if (accelerator == accel_toggle_accessibility_) {
+    WizardAccessibilityHelper::GetInstance()->ToggleAccessibility(this);
   } else {
     return false;
   }
   return true;
 }
 
 void NewUserView::RecreatePeculiarControls() {
   // PreferredSize reported by MenuButton (and TextField) is not able
   // to shrink, only grow; so recreate on text change.
   delete languages_menubutton_;
@@ skipping 333 matching lines @@
 
 void NewUserView::InitLink(views::Link** link) {
   *link = new views::Link(std::wstring());
   (*link)->SetController(this);
   (*link)->SetNormalColor(login::kLinkColor);
   (*link)->SetHighlightedColor(login::kLinkColor);
   AddChildView(*link);
 }
 
 }  // namespace chromeos