Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 5832001: Initialized the progress variable. (Closed)

Created:
10 years ago by asharif1
Modified:
9 years, 6 months ago
CC:
chromium-reviews, bjanakiraman1
Visibility:
Public.

Description

Initialized the progress variable. Note that I am not a chromium committer so you will have to commit this. This uninitialized variable causes problems in building chrome on chromeos since warnings are turned into errors. BUG=66886 TEST=submitted trybot

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/WebCore/page/animation/KeyframeAnimation.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
asharif1
Please review/commit this. I added you as the reviewer since that file seems to be ...
10 years ago (2010-12-14 22:45:30 UTC) #1
mattm
On 2010/12/14 22:45:30, asharif1 wrote: > Please review/commit this. I added you as the reviewer ...
10 years ago (2010-12-15 00:59:17 UTC) #2
asharif1
I have filed a bug upstream in WebKit: https://bugs.webkit.org/show_bug.cgi?id=51084 <https://bugs.webkit.org/show_bug.cgi?id=51084>Hopefully someone will fix this soon. ...
10 years ago (2010-12-15 02:32:27 UTC) #3
asharif1
9 years, 11 months ago (2011-01-13 22:39:59 UTC) #4
On 2010/12/15 02:32:27, asharif1 wrote:
> I have filed a bug upstream in WebKit:
> 
> https://bugs.webkit.org/show_bug.cgi?id=51084
> 
> <https://bugs.webkit.org/show_bug.cgi?id=51084%3EHopefully someone will fix
> this soon.
> 
> On Tue, Dec 14, 2010 at 4:59 PM, <mailto:mattm@chromium.org> wrote:
> 
> > On 2010/12/14 22:45:30, asharif1 wrote:
> >
> >> Please review/commit this. I added you as the reviewer since that file
> >> seems
> >>
> > to
> >
> >> be a third_party one.
> >>
> >
> > You should file this upstream, see
> > http://dev.chromium.org/developers/contributing-to-webkit
> >
> >
> >
> > http://codereview.chromium.org/5832001/
> >

The bug has been in WebKit for a while now:
https://bugs.webkit.org/process_bug.cgi

I have posted a patch there. Can you bring the patch into
chromium/third_party/WebKit?

(I am not a WebKit or Chromium committer).

Thanks,

Powered by Google App Engine
This is Rietveld 408576698