Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5828003: Move the Pepper implementation from webkit/glue/plugins/pepper_* to... (Closed)

Created:
10 years ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, Paweł Hajdan Jr., jam, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Move the Pepper implementation from webkit/glue/plugins/pepper_* to webkit/plugins/ppapi/*. This renamed the files and interface implementation classes from foo.cc/Foo to ppb_foo_impl/PPB_Foo_Impl to match the proxy ppb_foo_proxy/PPB_Foo_Proxy. This moves plugin_switches.* from webkit/glue/plugins to webkit/plugins. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69424

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2886 lines, -17324 lines) Patch
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/pepper_file_message_filter.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/pepper_file_message_filter.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/pepper_file_messages.h View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/pepper_file_messages.cc View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/common/pepper_plugin_registry.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/pepper_plugin_registry.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/pepper_platform_context_3d_impl.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/renderer/pepper_platform_context_3d_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper_plugin_delegate_impl.h View 1 2 6 chunks +22 lines, -15 lines 0 comments Download
M chrome/renderer/pepper_plugin_delegate_impl.cc View 1 2 21 chunks +38 lines, -33 lines 0 comments Download
M chrome/renderer/render_view.h View 1 2 3 chunks +13 lines, -8 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 2 6 chunks +12 lines, -10 lines 0 comments Download
MM chrome/renderer/render_widget_fullscreen_pepper.h View 1 2 4 chunks +13 lines, -7 lines 0 comments Download
MM chrome/renderer/render_widget_fullscreen_pepper.cc View 1 2 6 chunks +9 lines, -7 lines 0 comments Download
M chrome/test/ui/ppapi_uitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/dispatcher.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/proxy/ppapi_messages_internal.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_flash_proxy.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_flash_proxy.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_pdf_proxy.h View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M ppapi/proxy/ppb_pdf_proxy.cc View 1 2 6 chunks +15 lines, -15 lines 0 comments Download
D webkit/glue/plugins/mock_plugin_delegate.h View 1 2 1 chunk +0 lines, -98 lines 0 comments Download
D webkit/glue/plugins/mock_plugin_delegate.cc View 1 2 1 chunk +0 lines, -187 lines 0 comments Download
D webkit/glue/plugins/mock_resource.h View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
D webkit/glue/plugins/pepper_audio.h View 1 2 1 chunk +0 lines, -111 lines 0 comments Download
D webkit/glue/plugins/pepper_audio.cc View 1 2 1 chunk +0 lines, -351 lines 0 comments Download
D webkit/glue/plugins/pepper_buffer.h View 1 2 1 chunk +0 lines, -56 lines 0 comments Download
D webkit/glue/plugins/pepper_buffer.cc View 1 2 1 chunk +0 lines, -119 lines 0 comments Download
D webkit/glue/plugins/pepper_char_set.h View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
D webkit/glue/plugins/pepper_char_set.cc View 1 2 1 chunk +0 lines, -166 lines 0 comments Download
D webkit/glue/plugins/pepper_class.h View 1 2 1 chunk +0 lines, -66 lines 0 comments Download
D webkit/glue/plugins/pepper_common.h View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
D webkit/glue/plugins/pepper_cursor_control.h View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D webkit/glue/plugins/pepper_cursor_control.cc View 1 2 1 chunk +0 lines, -92 lines 0 comments Download
D webkit/glue/plugins/pepper_dir_contents.h View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
D webkit/glue/plugins/pepper_directory_reader.h View 1 2 1 chunk +0 lines, -51 lines 0 comments Download
D webkit/glue/plugins/pepper_directory_reader.cc View 1 2 1 chunk +0 lines, -160 lines 0 comments Download
D webkit/glue/plugins/pepper_error_util.h View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
D webkit/glue/plugins/pepper_error_util.cc View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
D webkit/glue/plugins/pepper_event_conversion.h View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
D webkit/glue/plugins/pepper_event_conversion.cc View 1 2 1 chunk +0 lines, -301 lines 0 comments Download
D webkit/glue/plugins/pepper_file_callbacks.h View 1 2 1 chunk +0 lines, -57 lines 0 comments Download
D webkit/glue/plugins/pepper_file_callbacks.cc View 1 2 1 chunk +0 lines, -99 lines 0 comments Download
D webkit/glue/plugins/pepper_file_chooser.h View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
D webkit/glue/plugins/pepper_file_chooser.cc View 1 2 1 chunk +0 lines, -165 lines 0 comments Download
D webkit/glue/plugins/pepper_file_io.h View 1 2 1 chunk +0 lines, -94 lines 0 comments Download
D webkit/glue/plugins/pepper_file_io.cc View 1 2 1 chunk +0 lines, -437 lines 0 comments Download
D webkit/glue/plugins/pepper_file_ref.h View 1 2 1 chunk +0 lines, -62 lines 0 comments Download
D webkit/glue/plugins/pepper_file_ref.cc View 1 2 1 chunk +0 lines, -347 lines 0 comments Download
D webkit/glue/plugins/pepper_file_system.h View 1 2 1 chunk +0 lines, -44 lines 0 comments Download
D webkit/glue/plugins/pepper_file_system.cc View 1 2 1 chunk +0 lines, -89 lines 0 comments Download
D webkit/glue/plugins/pepper_font.h View 1 2 1 chunk +0 lines, -53 lines 0 comments Download
D webkit/glue/plugins/pepper_font.cc View 1 2 1 chunk +0 lines, -298 lines 0 comments Download
D webkit/glue/plugins/pepper_fullscreen_container.h View 1 2 1 chunk +0 lines, -36 lines 0 comments Download
D webkit/glue/plugins/pepper_graphics_2d.h View 1 2 1 chunk +0 lines, -180 lines 0 comments Download
D webkit/glue/plugins/pepper_graphics_2d.cc View 1 2 1 chunk +0 lines, -642 lines 0 comments Download
D webkit/glue/plugins/pepper_graphics_3d.h View 1 2 1 chunk +0 lines, -88 lines 0 comments Download
D webkit/glue/plugins/pepper_graphics_3d.cc View 1 2 1 chunk +0 lines, -258 lines 0 comments Download
D webkit/glue/plugins/pepper_graphics_3d_gl.cc View 1 2 1 chunk +0 lines, -671 lines 0 comments Download
D webkit/glue/plugins/pepper_image_data.h View 1 2 1 chunk +0 lines, -131 lines 0 comments Download
D webkit/glue/plugins/pepper_image_data.cc View 1 2 1 chunk +0 lines, -218 lines 0 comments Download
D webkit/glue/plugins/pepper_plugin_delegate.h View 1 2 1 chunk +0 lines, -312 lines 0 comments Download
D webkit/glue/plugins/pepper_plugin_instance.h View 1 2 1 chunk +0 lines, -318 lines 0 comments Download
D webkit/glue/plugins/pepper_plugin_instance.cc View 1 2 1 chunk +0 lines, -1179 lines 0 comments Download
D webkit/glue/plugins/pepper_plugin_module.h View 1 2 1 chunk +0 lines, -180 lines 0 comments Download
D webkit/glue/plugins/pepper_plugin_module.cc View 1 2 1 chunk +0 lines, -492 lines 0 comments Download
D webkit/glue/plugins/pepper_plugin_object.h View 1 2 1 chunk +0 lines, -89 lines 0 comments Download
D webkit/glue/plugins/pepper_plugin_object.cc View 1 2 1 chunk +0 lines, -891 lines 0 comments Download
D webkit/glue/plugins/pepper_private.h View 1 2 1 chunk +0 lines, -23 lines 0 comments Download
D webkit/glue/plugins/pepper_private.cc View 1 2 1 chunk +0 lines, -302 lines 0 comments Download
D webkit/glue/plugins/pepper_private2.h View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
D webkit/glue/plugins/pepper_private2.cc View 1 2 1 chunk +0 lines, -243 lines 0 comments Download
D webkit/glue/plugins/pepper_private2_linux.cc View 1 2 1 chunk +0 lines, -110 lines 0 comments Download
D webkit/glue/plugins/pepper_resource.h View 1 2 1 chunk +0 lines, -140 lines 0 comments Download
D webkit/glue/plugins/pepper_resource.cc View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
D webkit/glue/plugins/pepper_resource_tracker.h View 1 2 1 chunk +0 lines, -147 lines 0 comments Download
D webkit/glue/plugins/pepper_resource_tracker.cc View 1 2 1 chunk +0 lines, -193 lines 0 comments Download
D webkit/glue/plugins/pepper_scrollbar.h View 1 2 1 chunk +0 lines, -62 lines 0 comments Download
D webkit/glue/plugins/pepper_scrollbar.cc View 1 2 1 chunk +0 lines, -246 lines 0 comments Download
D webkit/glue/plugins/pepper_string.h View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
D webkit/glue/plugins/pepper_string.cc View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D webkit/glue/plugins/pepper_transport.h View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
D webkit/glue/plugins/pepper_transport.cc View 1 2 1 chunk +0 lines, -144 lines 0 comments Download
D webkit/glue/plugins/pepper_url_loader.h View 1 2 1 chunk +0 lines, -140 lines 0 comments Download
D webkit/glue/plugins/pepper_url_loader.cc View 1 2 1 chunk +0 lines, -536 lines 0 comments Download
D webkit/glue/plugins/pepper_url_request_info.h View 1 2 1 chunk +0 lines, -69 lines 0 comments Download
D webkit/glue/plugins/pepper_url_request_info.cc View 1 2 1 chunk +0 lines, -282 lines 0 comments Download
D webkit/glue/plugins/pepper_url_response_info.h View 1 2 1 chunk +0 lines, -51 lines 0 comments Download
D webkit/glue/plugins/pepper_url_response_info.cc View 1 2 1 chunk +0 lines, -141 lines 0 comments Download
D webkit/glue/plugins/pepper_url_util.h View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
D webkit/glue/plugins/pepper_url_util.cc View 1 2 1 chunk +0 lines, -177 lines 0 comments Download
D webkit/glue/plugins/pepper_var.h View 1 2 1 chunk +0 lines, -251 lines 0 comments Download
D webkit/glue/plugins/pepper_var.cc View 1 2 1 chunk +0 lines, -869 lines 0 comments Download
D webkit/glue/plugins/pepper_video_decoder.h View 1 2 1 chunk +0 lines, -50 lines 0 comments Download
D webkit/glue/plugins/pepper_video_decoder.cc View 1 2 1 chunk +0 lines, -145 lines 0 comments Download
D webkit/glue/plugins/pepper_webplugin_impl.h View 1 2 1 chunk +0 lines, -95 lines 0 comments Download
D webkit/glue/plugins/pepper_webplugin_impl.cc View 1 2 1 chunk +0 lines, -226 lines 0 comments Download
D webkit/glue/plugins/pepper_widget.h View 1 2 1 chunk +0 lines, -53 lines 0 comments Download
D webkit/glue/plugins/pepper_widget.cc View 1 2 1 chunk +0 lines, -99 lines 0 comments Download
M webkit/glue/plugins/plugin_list.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D webkit/glue/plugins/plugin_switches.h View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
D webkit/glue/plugins/plugin_switches.cc View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
D webkit/glue/plugins/ppapi_unittest.h View 1 2 1 chunk +0 lines, -46 lines 0 comments Download
D webkit/glue/plugins/ppapi_unittest.cc View 1 2 1 chunk +0 lines, -113 lines 0 comments Download
D webkit/glue/plugins/ppb_private.h View 1 2 1 chunk +0 lines, -135 lines 0 comments Download
D webkit/glue/plugins/ppb_private2.h View 1 2 1 chunk +0 lines, -117 lines 0 comments Download
D webkit/glue/plugins/ppp_private.h View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
D webkit/glue/plugins/resource_tracker_unittest.cc View 1 2 1 chunk +0 lines, -116 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 4 chunks +92 lines, -76 lines 0 comments Download
A + webkit/module.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/module.cc View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + webkit/plugins/plugin_switches.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/plugins/plugin_switches.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + webkit/plugins/ppapi/common.h View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
A + webkit/plugins/ppapi/dir_contents.h View 1 2 1 chunk +12 lines, -5 lines 0 comments Download
A + webkit/plugins/ppapi/error_util.h View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
A + webkit/plugins/ppapi/error_util.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
A + webkit/plugins/ppapi/event_conversion.h View 1 2 3 chunks +7 lines, -5 lines 0 comments Download
A + webkit/plugins/ppapi/event_conversion.cc View 1 2 5 chunks +8 lines, -7 lines 0 comments Download
A + webkit/plugins/ppapi/file_callbacks.h View 1 2 4 chunks +13 lines, -11 lines 0 comments Download
A + webkit/plugins/ppapi/file_callbacks.cc View 1 2 2 chunks +16 lines, -12 lines 0 comments Download
A + webkit/plugins/ppapi/fullscreen_container.h View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
A + webkit/plugins/ppapi/mock_plugin_delegate.h View 1 2 3 chunks +11 lines, -9 lines 0 comments Download
A + webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 2 4 chunks +9 lines, -6 lines 0 comments Download
A + webkit/plugins/ppapi/mock_resource.h View 1 2 2 chunks +8 lines, -6 lines 0 comments Download
A webkit/plugins/ppapi/npapi_glue.h View 1 2 1 chunk +188 lines, -0 lines 0 comments Download
A webkit/plugins/ppapi/npapi_glue.cc View 1 2 1 chunk +199 lines, -0 lines 0 comments Download
A + webkit/plugins/ppapi/plugin_delegate.h View 1 2 6 chunks +14 lines, -12 lines 0 comments Download
A + webkit/plugins/ppapi/plugin_instance.h View 1 2 9 chunks +20 lines, -18 lines 0 comments Download
A + webkit/plugins/ppapi/plugin_instance.cc View 1 2 12 chunks +52 lines, -45 lines 0 comments Download
A + webkit/plugins/ppapi/plugin_module.h View 1 2 4 chunks +8 lines, -6 lines 0 comments Download
A + webkit/plugins/ppapi/plugin_module.cc View 1 2 5 chunks +105 lines, -99 lines 0 comments Download
A + webkit/plugins/ppapi/plugin_object.h View 1 2 3 chunks +7 lines, -5 lines 0 comments Download
A + webkit/plugins/ppapi/plugin_object.cc View 1 2 3 chunks +11 lines, -565 lines 0 comments Download
A + webkit/plugins/ppapi/ppapi_unittest.h View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
A + webkit/plugins/ppapi/ppapi_unittest.cc View 1 2 4 chunks +11 lines, -11 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_audio_impl.h View 1 2 6 chunks +27 lines, -22 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_audio_impl.cc View 1 2 18 chunks +62 lines, -48 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_buffer_impl.h View 1 2 2 chunks +15 lines, -16 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_buffer_impl.cc View 1 2 8 chunks +28 lines, -26 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_char_set_impl.h View 1 2 1 chunk +8 lines, -6 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_char_set_impl.cc View 1 2 4 chunks +12 lines, -9 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_cursor_control_impl.h View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_cursor_control_impl.cc View 1 2 3 chunks +14 lines, -12 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_directory_reader_impl.h View 1 2 2 chunks +14 lines, -12 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_directory_reader_impl.cc View 1 2 6 chunks +34 lines, -27 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_file_chooser_impl.h View 1 2 2 chunks +15 lines, -12 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_file_chooser_impl.cc View 1 2 10 chunks +29 lines, -25 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_file_io_impl.h View 1 2 4 chunks +19 lines, -13 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_file_io_impl.cc View 1 2 24 chunks +71 lines, -65 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_file_ref_impl.h View 1 2 2 chunks +25 lines, -21 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_file_ref_impl.cc View 1 2 13 chunks +62 lines, -50 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_file_system_impl.h View 1 2 2 chunks +13 lines, -9 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_file_system_impl.cc View 1 2 4 chunks +21 lines, -16 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_flash.h View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_flash_impl.h View 1 2 2 chunks +16 lines, -10 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_flash_impl.cc View 1 2 5 chunks +17 lines, -14 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_flash_impl_linux.cc View 1 2 3 chunks +18 lines, -16 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_font_impl.h View 1 2 2 chunks +15 lines, -10 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_font_impl.cc View 1 2 13 chunks +40 lines, -36 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_graphics_2d_impl.h View 1 2 8 chunks +18 lines, -16 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_graphics_2d_impl.cc View 1 2 23 chunks +82 lines, -68 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_graphics_3d_impl.h View 1 2 2 chunks +19 lines, -16 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_graphics_3d_impl.cc View 1 2 8 chunks +42 lines, -35 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_image_data_impl.h View 1 2 7 chunks +19 lines, -16 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_image_data_impl.cc View 1 2 11 chunks +41 lines, -29 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_open_gl_es_impl.cc View 1 2 2 chunks +149 lines, -147 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_pdf.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_pdf_impl.h View 1 2 1 chunk +12 lines, -10 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_pdf_impl.cc View 1 2 6 chunks +20 lines, -20 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_scrollbar_impl.h View 1 2 4 chunks +16 lines, -11 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_scrollbar_impl.cc View 1 2 14 chunks +47 lines, -37 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_transport_impl.h View 1 2 1 chunk +18 lines, -15 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_transport_impl.cc View 1 2 3 chunks +18 lines, -13 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_url_loader_impl.h View 1 2 8 chunks +23 lines, -18 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_url_loader_impl.cc View 1 2 31 chunks +91 lines, -68 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_url_request_info_impl.h View 1 2 2 chunks +17 lines, -12 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_url_request_info_impl.cc View 1 2 14 chunks +39 lines, -34 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_url_response_info_impl.h View 1 2 2 chunks +19 lines, -12 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_url_response_info_impl.cc View 1 2 7 chunks +24 lines, -19 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_url_util_impl.h View 1 2 1 chunk +8 lines, -6 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_url_util_impl.cc View 1 2 3 chunks +11 lines, -8 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_video_decoder_impl.h View 1 2 2 chunks +17 lines, -12 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_video_decoder_impl.cc View 1 2 7 chunks +36 lines, -29 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_widget_impl.h View 1 2 2 chunks +17 lines, -12 lines 0 comments Download
A + webkit/plugins/ppapi/ppb_widget_impl.cc View 1 2 4 chunks +31 lines, -21 lines 0 comments Download
A + webkit/plugins/ppapi/ppp_pdf.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
A + webkit/plugins/ppapi/resource.h View 1 2 3 chunks +30 lines, -30 lines 0 comments Download
A + webkit/plugins/ppapi/resource.cc View 1 2 2 chunks +12 lines, -4 lines 0 comments Download
A + webkit/plugins/ppapi/resource_tracker.h View 1 2 4 chunks +12 lines, -7 lines 0 comments Download
A + webkit/plugins/ppapi/resource_tracker.cc View 1 2 3 chunks +12 lines, -5 lines 0 comments Download
A + webkit/plugins/ppapi/resource_tracker_unittest.cc View 1 2 2 chunks +8 lines, -5 lines 0 comments Download
A + webkit/plugins/ppapi/string.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
A + webkit/plugins/ppapi/string.cc View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
A + webkit/plugins/ppapi/var.h View 1 2 6 chunks +11 lines, -9 lines 0 comments Download
A + webkit/plugins/ppapi/var.cc View 1 2 10 chunks +30 lines, -11 lines 0 comments Download
A + webkit/plugins/ppapi/var_object_class.h View 1 2 3 chunks +21 lines, -10 lines 0 comments Download
A webkit/plugins/ppapi/var_object_class.cc View 1 2 1 chunk +286 lines, -0 lines 0 comments Download
A + webkit/plugins/ppapi/webplugin_impl.h View 1 2 3 chunks +9 lines, -7 lines 0 comments Download
A + webkit/plugins/ppapi/webplugin_impl.cc View 1 2 5 chunks +11 lines, -8 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 2 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
10 years ago (2010-12-15 22:24:59 UTC) #1
jam
10 years ago (2010-12-15 22:45:48 UTC) #2 
lgtm

http://codereview.chromium.org/5828003/diff/1/ppapi/proxy/ppb_pdf_proxy.h
File ppapi/proxy/ppb_pdf_proxy.h (right):

http://codereview.chromium.org/5828003/diff/1/ppapi/proxy/ppb_pdf_proxy.h#new...
ppapi/proxy/ppb_pdf_proxy.h:11: struct PPB_Pdf;
nit: we use PDF everywhere in the plugin code, since it's an acronym.  can you
make it PDF?

http://codereview.chromium.org/5828003/diff/1/webkit/glue/webkit_glue.gypi
File webkit/glue/webkit_glue.gypi (right):

http://codereview.chromium.org/5828003/diff/1/webkit/glue/webkit_glue.gypi#ne...
webkit/glue/webkit_glue.gypi:171: '../plugins/plugin_switches.cc',
hmm, having "../" in a gyp file seems like a signal that another gyp file is
needed for that directory

http://codereview.chromium.org/5828003/diff/1/webkit/glue/webkit_glue.gypi#ne...
webkit/glue/webkit_glue.gypi:173: 
nit: why the blank line?

http://codereview.chromium.org/5828003/diff/1/webkit/glue/webkit_glue.gypi#ne...
webkit/glue/webkit_glue.gypi:254: 
nit: ditto

Powered by Google App Engine
This is Rietveld 408576698