Issue 582020: Add bounds checking to StaticSocketDataProvider, to make tests more reliable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 582020: Add bounds checking to StaticSocketDataProvider, to make tests more reliable (Closed)

Created:
10 years, 10 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe, eroman, wtc

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Add bounds checking to StaticSocketDataProvider, to make tests more reliable when they fail. TEST=net_unittests BUG=27567 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38453

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+288 lines, -167 lines)			Patch
M	net/ftp/ftp_network_transaction_unittest.cc	View	5 chunks	+10 lines, -6 lines	0 comments	Download
M	net/http/http_network_layer_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/http/http_network_transaction_unittest.cc	View	69 chunks	+154 lines, -85 lines	0 comments	Download
M	net/socket/socket_test_util.h	View	1 chunk	+17 lines, -12 lines	0 comments	Download
M	net/socket/socket_test_util.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	net/socket/socks5_client_socket_unittest.cc	View	9 chunks	+26 lines, -8 lines	0 comments	Download
M	net/socket/socks_client_socket_unittest.cc	View	10 chunks	+30 lines, -18 lines	0 comments	Download
M	net/socket_stream/socket_stream_unittest.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_network_transaction_unittest.cc	View	24 chunks	+37 lines, -28 lines	0 comments	Download
M	net/websockets/websocket_unittest.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

LGTM