net/http/http_network_layer_unittest.cc - Issue 582020: Add bounds checking to StaticSocketDataProvider, to make tests more reliable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_layer_unittest.cc

Issue 582020: Add bounds checking to StaticSocketDataProvider, to make tests more reliable (Closed)

Patch Set: Created 10 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_network_layer_unittest.cc

diff --git a/net/http/http_network_layer_unittest.cc b/net/http/http_network_layer_unittest.cc

index 1e75ecef4aeef4cb1f4d2ca589b75d25f999bc21..84253046bd76bedf6286cdfe14884e953ac04f84 100644

--- a/net/http/http_network_layer_unittest.cc

+++ b/net/http/http_network_layer_unittest.cc

@@ -62,7 +62,8 @@ TEST_F(HttpNetworkLayerTest, GET) {

"Connection: keep-alive\r\n"

"User-Agent: Foo/1.0\r\n\r\n"),

};

- net::StaticSocketDataProvider data(data_reads, data_writes);

+ net::StaticSocketDataProvider data(data_reads, arraysize(data_reads),

+ data_writes, arraysize(data_reads));

mock_socket_factory.AddSocketDataProvider(&data);

net::HttpNetworkLayer factory(&mock_socket_factory, NULL,