chrome/renderer/renderer_glue.cc - Issue 5815001: Fixed file_version_info so that it finds Mac values correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/renderer_glue.cc

Issue 5815001: Fixed file_version_info so that it finds Mac values correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changed logging to vlog Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/renderer_glue.cc

diff --git a/chrome/renderer/renderer_glue.cc b/chrome/renderer/renderer_glue.cc

index 9d706132ded568e2fa11f0732fe559ca81c55946..f73fcc45e3638d8e15f35717a875cc15852fa8e2 100644

--- a/chrome/renderer/renderer_glue.cc

+++ b/chrome/renderer/renderer_glue.cc

@@ -256,8 +256,7 @@ void ClearCache() {

std::string GetProductVersion() {

chrome::VersionInfo version_info;

std::string product("Chrome/");

- product += version_info.is_valid() ? version_info.Version()

- : "0.0.0.0";

+ product += version_info.Version();

return product;

}