chrome/common/service_process_util_unittest.cc - Issue 5815001: Fixed file_version_info so that it finds Mac values correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/service_process_util_unittest.cc

Issue 5815001: Fixed file_version_info so that it finds Mac values correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changed logging to vlog Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/service_process_util_unittest.cc

diff --git a/chrome/common/service_process_util_unittest.cc b/chrome/common/service_process_util_unittest.cc

index 58b68e1a34134bb7c5c3dbd10832165fc674d0ca..34b855ab3c1a5788a42932d633b011ceaff60261 100644

--- a/chrome/common/service_process_util_unittest.cc

+++ b/chrome/common/service_process_util_unittest.cc

@@ -14,7 +14,6 @@ TEST(ServiceProcessUtilTest, ScopedVersionedName) {

std::string test_str = "test";

std::string scoped_name = GetServiceProcessScopedVersionedName(test_str);

chrome::VersionInfo version_info;

- DCHECK(version_info.is_valid());

EXPECT_TRUE(EndsWith(scoped_name, test_str, true));

EXPECT_NE(std::string::npos, scoped_name.find(version_info.Version()));

}