Minimize login prompts

chrome/browser/ui/login/login_prompt.h

Index: chrome/browser/ui/login/login_prompt.h
diff --git a/chrome/browser/ui/login/login_prompt.h b/chrome/browser/ui/login/login_prompt.h
index 8e3d15e0dc5f714997546b6bdef97baa2a1e9a0e..ea1f887f632491d3a91ad94bd335dd93dc34df9b 100644
--- a/chrome/browser/ui/login/login_prompt.h
+++ b/chrome/browser/ui/login/login_prompt.h
@@ -70,6 +70,9 @@ class LoginHandler : public base::RefCountedThreadSafe<LoginHandler>,
                        const NotificationSource& source,
                        const NotificationDetails& details);
 
+  // Who/where/what asked for the authentication.
+  net::AuthChallengeInfo* auth_info() const { return auth_info_.get(); }

[cbentzel, 2010/12/17 19:22:56]

I know that you just moved this from protected to public, but this should
probably not be a const method if it returns a non-const AuthChallengeInfo*
which it uses internally [the assumption being that mutations can be done on it
from outside]. 

[asanka (google), 2010/12/17 21:35:35]

I'll defer this to another CL since there are other consumers of auth_info().

+
  protected:
   void SetModel(LoginModel* model);
 
@@ -81,9 +84,6 @@ class LoginHandler : public base::RefCountedThreadSafe<LoginHandler>,
   // Performs necessary cleanup before deletion.
   void ReleaseSoon();
 
-  // Who/where/what asked for the authentication.
-  net::AuthChallengeInfo* auth_info() const { return auth_info_.get(); }
-
  private:
   // Starts observing notifications from other LoginHandlers.
   void AddObservers();