Minimize login prompts

chrome/browser/ui/login/login_prompt.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_LOGIN_LOGIN_PROMPT_H_
 #define CHROME_BROWSER_UI_LOGIN_LOGIN_PROMPT_H_
 #pragma once
 
 #include <string>
 
@@ skipping 52 matching lines @@
   void OnRequestCancelled();
 
   // Implements the NotificationObserver interface.
   // Listens for AUTH_SUPPLIED and AUTH_CANCELLED notifications from other
   // LoginHandlers so that this LoginHandler has the chance to dismiss itself
   // if it was waiting for the same authentication.
   virtual void Observe(NotificationType type,
                        const NotificationSource& source,
                        const NotificationDetails& details);
 
+  // Who/where/what asked for the authentication.
+  net::AuthChallengeInfo* auth_info() const { return auth_info_.get(); }

[cbentzel, 2010/12/17 19:22:56]

I know that you just moved this from protected to public, but this should
probably not be a const method if it returns a non-const AuthChallengeInfo*
which it uses internally [the assumption being that mutations can be done on it
from outside]. 

[asanka (google), 2010/12/17 21:35:35]

I'll defer this to another CL since there are other consumers of auth_info().

+
  protected:
   void SetModel(LoginModel* model);
 
   void SetDialog(ConstrainedWindow* dialog);
 
   // Notify observers that authentication is needed.
   void NotifyAuthNeeded();
 
   // Performs necessary cleanup before deletion.
   void ReleaseSoon();
 
-  // Who/where/what asked for the authentication.
-  net::AuthChallengeInfo* auth_info() const { return auth_info_.get(); }
-
  private:
   // Starts observing notifications from other LoginHandlers.
   void AddObservers();
 
   // Stops observing notifications from other LoginHandlers.
   void RemoveObservers();
 
   // Notify observers that authentication is supplied.
   void NotifyAuthSupplied(const std::wstring& username,
                           const std::wstring& password);
@@ skipping 108 matching lines @@
 // Helper to remove the ref from an net::URLRequest to the LoginHandler.
 // Should only be called from the IO thread, since it accesses an
 // net::URLRequest.
 void ResetLoginHandlerForRequest(net::URLRequest* request);
 
 // Get the signon_realm under which the identity should be saved.
 std::string GetSignonRealm(const GURL& url,
                            const net::AuthChallengeInfo& auth_info);
 
 #endif  // CHROME_BROWSER_UI_LOGIN_LOGIN_PROMPT_H_