Minimize login prompts

chrome/browser/ui/login/login_prompt.cc

Index: chrome/browser/ui/login/login_prompt.cc
diff --git a/chrome/browser/ui/login/login_prompt.cc b/chrome/browser/ui/login/login_prompt.cc
index d653457de8ed16f517d42939b3146bac51be62ce..ec619088adf91ac8903d7759a9d876b6c22c57b8 100644
--- a/chrome/browser/ui/login/login_prompt.cc
+++ b/chrome/browser/ui/login/login_prompt.cc
@@ -196,17 +196,17 @@ void LoginHandler::Observe(NotificationType type,
   if (!requesting_contents)
     return;
 
-  NavigationController* this_controller = &requesting_contents->controller();
-  NavigationController* that_controller =
-      Source<NavigationController>(source).ptr();
-
-  // Only handle notifications from other handlers.
-  if (this_controller == that_controller)
+  // Break out early if we aren't interested in the notification.
+  if (WasAuthHandled(false))

[cbentzel, 2010/12/17 19:22:56]

I know the code already existed like this, but I'm wondering if you should
change this class to have

bool WasAuthHandled() const;
bool TestAndSetAuthHandled();

Passing in the boolean makes it pretty unclear what is going on.

It's fine to defer this cleanup to another CL. 

[asanka (google), 2010/12/17 21:35:35]

I'll defer this for another CL.  I agree with the comment.

     return;
 
   LoginNotificationDetails* login_details =
       Details<LoginNotificationDetails>(details).ptr();
 
+  // WasAuthHandled(false) should always test positive before we
+  // publish AUTH_SUPPLIED or AUTH_CANCELLED notifications.
+  DCHECK(login_details->handler() != this);
+
   // Only handle notification for the identical auth info.
   if (*login_details->handler()->auth_info() != *auth_info())
     return;