Issue 5796005: vboot TPM stub functions return error codes

Issue 5796005: vboot TPM stub functions return error codes (Closed)

Created:
10 years ago by Che-Liang Chiou

Modified:
9 years ago

Reviewers:
Randall Spangler, Luigi Semenzato

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Bill Richardson, Luigi Semenzato

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master

Visibility:
Public.

Description

vboot TPM stub functions return error codes TlclStubInit, TlclCloseDevice, and TlclOpenDevice were void functions but should return error codes. BUG=chromium-os:6695 TEST=RUNTESTS=1 make && emerge successfully Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=5d9509c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Respond to code reviews #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -20 lines)			Patch
M	firmware/include/tlcl_stub.h	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	firmware/include/tss_constants.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	firmware/lib/rollback_index.c	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	firmware/lib/tpm_lite/include/tlcl.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	firmware/lib/tpm_lite/tlcl.c	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	firmware/stub/tpm_lite_stub.c	View	1	2 chunks	+15 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

One small change. LGTM after that. http://codereview.chromium.org/5796005/diff/1/firmware/stub/tpm_lite_stub.c File firmware/stub/tpm_lite_stub.c (right): http://codereview.chromium.org/5796005/diff/1/firmware/stub/tpm_lite_stub.c#newcode108 firmware/stub/tpm_lite_stub.c:108: close(tpm_fd); if (tpm_fd ...

10 years ago (2010-12-14 18:12:28 UTC) #2

Luigi Semenzato

Note that error() calls exit(), so that error is never returned. Maybe you want to ...

10 years ago (2010-12-14 19:01:59 UTC) #3

Che-Liang Chiou

Also change error() to VBDEBUG() based on Luigi Semenzato's comments. http://codereview.chromium.org/5796005/diff/1/firmware/stub/tpm_lite_stub.c File firmware/stub/tpm_lite_stub.c (right): http://codereview.chromium.org/5796005/diff/1/firmware/stub/tpm_lite_stub.c#newcode108 ...

10 years ago (2010-12-15 03:04:37 UTC) #4

LGTM, thanks

Expand Messages | Collapse Messages