vboot TPM stub functions return error codes

firmware/lib/rollback_index.c

 /* Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  *
  * Functions for querying, manipulating and locking rollback indices
  * stored in the TPM NVRAM.
  */
 
 #include "rollback_index.h"
 
@@ skipping 179 matching lines @@
   uint8_t disable;
   uint8_t deactivated;
   uint32_t result;
 
   VBDEBUG(("TPM: SetupTPM(r%d, d%d)\n", recovery_mode, developer_mode));
 
   if (recovery_mode)
     g_rollback_recovery_mode = 1;  /* Global variables are usable in
                                     * recovery mode */
 
-  /* TODO: TlclLibInit() should be able to return failure */
-  TlclLibInit();
+  RETURN_ON_FAILURE(TlclLibInit());
 
   RETURN_ON_FAILURE(TlclStartup());
   /* Use ContinueSelfTest rather than SelfTestFull().  It enables
    * access to the subset of TPM commands we need in the firmware, and
    * allows the full self test to run in paralle with firmware
    * startup.  By the time we get to the OS, self test will have
    * completed. */
   RETURN_ON_FAILURE(TlclContinueSelfTest());
   result = TlclAssertPhysicalPresence();
   if (result != 0) {
@@ skipping 117 matching lines @@
 }
 
 uint32_t RollbackKernelLock(void) {
   return TPM_SUCCESS;
 }
 
 #else
 
 uint32_t RollbackS3Resume(void) {
   uint32_t result;
-  TlclLibInit();
+  RETURN_ON_FAILURE(TlclLibInit());
   result = TlclResume();
   if (result == TPM_E_INVALID_POSTINIT) {
     /* We're on a platform where the TPM maintains power in S3, so
        it's already initialized. */
     return TPM_SUCCESS;
   }
   return result;
 }
 
 
@@ skipping 89 matching lines @@
 
 uint32_t RollbackKernelLock(void) {
   if (g_rollback_recovery_mode) {
     return TPM_SUCCESS;
   } else {
     return TlclLockPhysicalPresence();
   }
 }
 
 #endif // DISABLE_ROLLBACK_TPM