Issue 5783004: Keep deinlining stuff.

Issue 5783004: Keep deinlining stuff. (Closed)

Created:
10 years ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, James Hawkins

CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Paweł Hajdan Jr., jam, darin-cc_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org, tim (not reviewing), amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Keep deinlining stuff. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69273

Patch Set 2 : Fix for chrome_frame #

Patch Set 3 : More fixes for chrome_frame #

Patch Set 4 : More fixes for chrome_frame #

Patch Set 6 : More chrome_frame #

Patch Set 7 : Well, it all compiles locally? #

Total comments: 3

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1112 lines, -545 lines)			Patch
M	app/app_base.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	app/gfx/gl/gl_context_stub.h	View		1 chunk	+9 lines, -7 lines	0 comments	Download
A	app/gfx/gl/gl_context_stub.cc	View		1 chunk	+39 lines, -0 lines	0 comments	Download
M	app/gfx/gl/gl_implementation_linux.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/automation/automation_autocomplete_edit_tracker.h	View		1 chunk	+4 lines, -17 lines	0 comments	Download
A	chrome/browser/automation/automation_autocomplete_edit_tracker.cc	View		1 chunk	+28 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/automation_browser_tracker.h	View		1 chunk	+4 lines, -13 lines	0 comments	Download
A	chrome/browser/automation/automation_browser_tracker.cc	View		1 chunk	+24 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/url_request_automation_job.cc	View		1 chunk	+8 lines, -9 lines	0 comments	Download
M	chrome/browser/external_tab_container_win.cc	View	1 2 3	1 chunk	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/gtk/accessibility_event_router_gtk.cc	View		1 chunk	+1 line, -1 line	1 comment	Download
M	chrome/browser/gtk/translate/after_translate_infobar_gtk.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/translate/after_translate_infobar_gtk.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/translate/before_translate_infobar_gtk.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/translate/before_translate_infobar_gtk.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/prerender/prerender_contents.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/prerender/prerender_contents.cc	View		2 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view.h	View		2 chunks	+3 lines, -5 lines	0 comments	Download
A	chrome/browser/renderer_host/render_widget_host_view.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/glue/password_data_type_controller.h	View		1 chunk	+5 lines, -16 lines	0 comments	Download
M	chrome/browser/sync/glue/password_data_type_controller.cc	View		1 chunk	+21 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/glue/password_model_associator.h	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/sync/glue/password_model_associator.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/chrome_common.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/automation_messages.h	View	1 2 3 4	8 chunks	+99 lines, -390 lines	0 comments	Download
M	chrome/common/automation_messages.cc	View	1 2 3	1 chunk	+667 lines, -0 lines	0 comments	Download
M	chrome/common/pref_store.h	View		1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/common/pref_store.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/test/automation/automation_proxy_uitest.h	View	1 2 3 4 5 6	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/test/automation/automation_proxy_uitest.cc	View	1 2 3 4 5 6	7 chunks	+27 lines, -15 lines	0 comments	Download
M	chrome_frame/cfproxy_test.cc	View	1 2 3 4 5	4 chunks	+9 lines, -8 lines	0 comments	Download
M	chrome_frame/chrome_frame_automation.cc	View	1 2	2 chunks	+14 lines, -16 lines	0 comments	Download
M	chrome_frame/test/url_request_test.cc	View	1 2 3 4 5	3 chunks	+4 lines, -5 lines	0 comments	Download
M	gfx/canvas.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	gfx/canvas.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	gfx/gfx.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/plugins/webplugin_impl.h	View		3 chunks	+3 lines, -5 lines	0 comments	Download
M	webkit/glue/plugins/webplugin_impl.cc	View		3 chunks	+12 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/webplugin_print_delegate.h	View		2 chunks	+5 lines, -11 lines	2 comments	Download
A	webkit/glue/plugins/webplugin_print_delegate.cc	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

LGTM with nits below. http://codereview.chromium.org/5783004/diff/14001/chrome/browser/gtk/accessibility_event_router_gtk.cc File chrome/browser/gtk/accessibility_event_router_gtk.cc (right): http://codereview.chromium.org/5783004/diff/14001/chrome/browser/gtk/accessibility_event_router_gtk.cc#newcode17 chrome/browser/gtk/accessibility_event_router_gtk.cc:17: #include "views/controls/textfield/native_textfield_gtk.h" nit: n after ...

10 years ago (2010-12-15 00:51:35 UTC) #2

Elliot Glaysher

10 years ago (2010-12-15 17:34:40 UTC) #3

http://codereview.chromium.org/5783004/diff/14001/webkit/glue/plugins/webplug...
File webkit/glue/plugins/webplugin_print_delegate.h (right):

http://codereview.chromium.org/5783004/diff/14001/webkit/glue/plugins/webplug...
webkit/glue/plugins/webplugin_print_delegate.h:10: #include
"third_party/WebKit/WebKit/chromium/public/WebCanvas.h"
On 2010/12/15 00:51:35, Lei Zhang wrote:
> You can't forward declare WebKit::WebCanvas?

Nope. It's a bunch of ifdefed typedefs.

Expand Messages | Collapse Messages