Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view.h

Issue 5783004: Keep deinlining stuff. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Well, it all compiles locally? Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/render_widget_host_view.h
diff --git a/chrome/browser/renderer_host/render_widget_host_view.h b/chrome/browser/renderer_host/render_widget_host_view.h
index 14cf129cdc0996c5e6b5a9c0a1107e8f49d38881..fdbe4408ccff28da6dff11f8a6719834d19ab6d7 100644
--- a/chrome/browser/renderer_host/render_widget_host_view.h
+++ b/chrome/browser/renderer_host/render_widget_host_view.h
@@ -51,7 +51,7 @@ struct WebPluginGeometry;
// changes.
class RenderWidgetHostView {
public:
- virtual ~RenderWidgetHostView() {}
+ virtual ~RenderWidgetHostView();
// Platform-specific creator. Use this to construct new RenderWidgetHostViews
// rather than using RenderWidgetHostViewWin & friends.
@@ -268,11 +268,9 @@ class RenderWidgetHostView {
}
WebKit::WebPopupType popup_type() const { return popup_type_; }
- // Subclasses should override this method to do is appropriate to set
+ // Subclasses should override this method to do what is appropriate to set
// the custom background for their platform.
- virtual void SetBackground(const SkBitmap& background) {
- background_ = background;
- }
+ virtual void SetBackground(const SkBitmap& background);
const SkBitmap& background() const { return background_; }
// Returns true if the native view, |native_view|, is contained within in the

Powered by Google App Engine
This is Rietveld 408576698