Support app menu and double-click close on upper left corner of window, part ...

Support app menu and double-click close on upper left corner of window, part one.

This makes things work right for windows that have an icon.  The behavior of the main window is unchanged because right now it never returns HTSYSMENU anywhere.  Part two of this change will be figuring out how to return that at the right place, which will make things Just Work.

BUG=6961
TEST=Open an app or popup window.  Single click the icon.  The app menu should appear.  Close it, then click-and-drag into the app menu.  The item you release on should execute.  Double-click the icon.  The window should close.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38187

[Ben Goodger (Google), 2010-02-05 03:27:25]

LGTM, just a question for my information.

http://codereview.chromium.org/577018/diff/1/6
File views/window/window_win.cc (right):

http://codereview.chromium.org/577018/diff/1/6#newcode994
views/window/window_win.cc:994: ExecuteSystemMenuCommand(id);
This is all because we called SetCapture right? i.e. if we didn't call
SetCapture there would be default handling for WM_NCRBUTTONUP that'd do this for
us?

[Peter Kasting, 2010-02-05 05:01:06]

http://codereview.chromium.org/577018/diff/1/6
File views/window/window_win.cc (right):

http://codereview.chromium.org/577018/diff/1/6#newcode994
views/window/window_win.cc:994: ExecuteSystemMenuCommand(id);
On 2010/02/05 03:27:25, Ben Goodger wrote:
> This is all because we called SetCapture right? i.e. if we didn't call
> SetCapture there would be default handling for WM_NCRBUTTONUP that'd do this
for
> us?

Sadly, no.  I tried this, and then I tried making WM_NCRBUTTONUP fire
WM_CONTEXTMENU, and then I tried SetCapture() and making WM_RBUTTONUP do it, and
none worked.  The Spy++ info from the Windows Live Photo Gallery app was very
confusing; most of the time it looked like something on their end was doing
capture and TrackPopupMenu(), but sometimes it was just WM_CONTEXTMENU. 
Bizarre.  Anyway, this part of the old code worked fine so I just kept it.

[Ben Goodger (Google), 2010-02-05 05:15:53]

OK. Sad that we still have to call TPM.

-Ben

On Thu, Feb 4, 2010 at 9:01 PM,  <pkasting@chromium.org> wrote:
>
> http://codereview.chromium.org/577018/diff/1/6
> File views/window/window_win.cc (right):
>
> http://codereview.chromium.org/577018/diff/1/6#newcode994
> views/window/window_win.cc:994: ExecuteSystemMenuCommand(id);
> On 2010/02/05 03:27:25, Ben Goodger wrote:
>>
>> This is all because we called SetCapture right? i.e. if we didn't call
>> SetCapture there would be default handling for WM_NCRBUTTONUP that'd
>
> do this for
>>
>> us?
>
> Sadly, no.  I tried this, and then I tried making WM_NCRBUTTONUP fire
> WM_CONTEXTMENU, and then I tried SetCapture() and making WM_RBUTTONUP do
> it, and none worked.  The Spy++ info from the Windows Live Photo Gallery
> app was very confusing; most of the time it looked like something on
> their end was doing capture and TrackPopupMenu(), but sometimes it was
> just WM_CONTEXTMENU.  Bizarre.  Anyway, this part of the old code worked
> fine so I just kept it.
>
> http://codereview.chromium.org/577018
>

[Finnur, 2011-02-16 15:34:31]

I suspect this CL of causing this regression:
http://code.google.com/p/chromium/issues/detail?id=73158

On 2010/02/05 05:15:53, Ben Goodger wrote:
> OK. Sad that we still have to call TPM.
> 
> -Ben
> 
> On Thu, Feb 4, 2010 at 9:01 PM,  <mailto:pkasting@chromium.org> wrote:
> >
> > http://codereview.chromium.org/577018/diff/1/6
> > File views/window/window_win.cc (right):
> >
> > http://codereview.chromium.org/577018/diff/1/6#newcode994
> > views/window/window_win.cc:994: ExecuteSystemMenuCommand(id);
> > On 2010/02/05 03:27:25, Ben Goodger wrote:
> >>
> >> This is all because we called SetCapture right? i.e. if we didn't call
> >> SetCapture there would be default handling for WM_NCRBUTTONUP that'd
> >
> > do this for
> >>
> >> us?
> >
> > Sadly, no. &nbsp;I tried this, and then I tried making WM_NCRBUTTONUP fire
> > WM_CONTEXTMENU, and then I tried SetCapture() and making WM_RBUTTONUP do
> > it, and none worked. &nbsp;The Spy++ info from the Windows Live Photo
Gallery
> > app was very confusing; most of the time it looked like something on
> > their end was doing capture and TrackPopupMenu(), but sometimes it was
> > just WM_CONTEXTMENU. &nbsp;Bizarre. &nbsp;Anyway, this part of the old code
worked
> > fine so I just kept it.
> >
> > http://codereview.chromium.org/577018
> >