Make us save favicon in incognito mode if the url is bookmarked. This

chrome/browser/history/history.h

Index: chrome/browser/history/history.h
diff --git a/chrome/browser/history/history.h b/chrome/browser/history/history.h
index 3fe34bade187728dba469bf437d3450cc9a849e2..b24d213d0def7d376451a63ba88679dea595d79c 100644
--- a/chrome/browser/history/history.h
+++ b/chrome/browser/history/history.h
@@ -212,6 +212,11 @@ class HistoryService : public CancelableRequestProvider,
   // All AddPage variants end up here.
   void AddPage(const history::HistoryAddPageArgs& add_page_args);
 
+  // Adds an entry for the specified url without creating a visit. Typically
+  // you'll use one of the AddPage variants. This should only be used in cases
+  // where you want to force adding an entry with no visits.
+  void AddPageNoVisit(const GURL& url);

[brettw, 2010/12/15 17:32:47]

Maybe we should call this AddPageNoVisitForBookmark or something? This should
not be called if the page is not bookmarked or the URL row will be "leaked."
Normally expiration & deletion are done via the visits, so adding a
non-bookmarked URL with no visits means its orphaned. I'd like the emphasize the
valid use here (can you also say this in the comment?).

[sky, 2010/12/15 18:00:46]

Done.

+
   // Sets the title for the given page. The page should be in history. If it
   // is not, this operation is ignored. This call will not update the full
   // text index. The last title set when the page is indexed will be the