Make us save favicon in incognito mode if the url is bookmarked. This

chrome/browser/history/history.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_HISTORY_HISTORY_H_
 #define CHROME_BROWSER_HISTORY_HISTORY_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 194 matching lines @@
 
   // For adding pages to history where no tracking information can be done.
   void AddPage(const GURL& url, history::VisitSource visit_source) {
     AddPage(url, NULL, 0, GURL(), PageTransition::LINK,
             history::RedirectList(), visit_source, false);
   }
 
   // All AddPage variants end up here.
   void AddPage(const history::HistoryAddPageArgs& add_page_args);
 
+  // Adds an entry for the specified url without creating a visit. Typically
+  // you'll use one of the AddPage variants. This should only be used in cases
+  // where you want to force adding an entry with no visits.
+  void AddPageNoVisit(const GURL& url);

[brettw, 2010/12/15 17:32:47]

Maybe we should call this AddPageNoVisitForBookmark or something? This should
not be called if the page is not bookmarked or the URL row will be "leaked."
Normally expiration & deletion are done via the visits, so adding a
non-bookmarked URL with no visits means its orphaned. I'd like the emphasize the
valid use here (can you also say this in the comment?).

[sky, 2010/12/15 18:00:46]

Done.

+
   // Sets the title for the given page. The page should be in history. If it
   // is not, this operation is ignored. This call will not update the full
   // text index. The last title set when the page is indexed will be the
   // title in the full text index.
   void SetPageTitle(const GURL& url, const string16& title);
 
   // Indexing ------------------------------------------------------------------
 
   // Notifies history of the body text of the given recently-visited URL.
   // If the URL was not visited "recently enough," the history system may
@@ skipping 631 matching lines @@
   BookmarkService* bookmark_service_;
   bool no_db_;
 
   // True if needs top site migration.
   bool needs_top_sites_migration_;
 
   DISALLOW_COPY_AND_ASSIGN(HistoryService);
 };
 
 #endif  // CHROME_BROWSER_HISTORY_HISTORY_H_